reverse() and get_absolute_url() may return different values for same FlatPage

[allo@…]

The FlatPage model implements get_absolute_url() without using reverse(). The comment suggests, that this handles SCRIPT_NAME issues, but the link in the admin interface does not work, if you are using a prefix for the flatpages urls. The templatetag for resolving a flatpage works just fine.

[Aymeric Augustin]

The implementation is intended to match the catchall middleware.

We could try reversing and only if that fails fall back to the current logic.

[edanm]

I just sent a pull request for a fix for this:
​https://github.com/django/django/pull/2554

This solves all the cases I can think of for including flatpages and running get_absolute_url() on them.

By the way, not sure if this is relevant, but:
When I was writing the tests for this, I noticed that all the flatpages tests include the flatpages url without a slash, e.g.:
url(r'flatpage_root', include('django.contrib.flatpages.urls')), (Note lack of '/' after flatpage_root).

This is different than how the documentation recommends including the flatpages, and doesn't make much sense. Not sure what the purpose of this is.

[Tim Graham]

I left comments for improvement on the PR. Please uncheck "Patch needs improvement" when you update it, thanks.

[Tim Graham]

#28118 is a duplicate.

[Hasan Ramezani]

I created another ​PR based on the ​first PR.

[Mariusz Felisiak <felisiak.mariusz@…>]

In e2fab0b:

Refs #22261 -- Added missing trailing slash to the flatpages_tests urls.

[Mariusz Felisiak <felisiak.mariusz@…>]

In 2633c534:

Fixed #22261 -- Fixed resolving namespaced URLs for flatpages.