Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#22255 closed Cleanup/optimization (fixed)

RegexValidator needs support for flags passed to `re.compile` (migrations do not allow for compiled patterns)

Reported by: Daniel Hahler Owned by: Dejan Noveski
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: Dejan Noveski Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no


When using a RegexValidator with a compiled pattern, makemigration fails:

ValueError: Cannot serialize: <_sre.SRE_Pattern object at 0x24e8ac0>

A sample model:

from django.core.validators import RegexValidator
pattern = re.compile(r'foo', re.IGNORECASE)
validator = RegexValidator(pattern)

class Model(models.Model):
    foo = models.CharField(
        validators = [validator],

This is somehow expected, and when passing in the pattern uncompiled it works.
But this won't allow to use re.IGNORE_CASE or other flags for re.compile anymore.

RegexValidator should support a new argument flags, which would then be used for non-compiled patterns (passed on to re.compile).

Let me know, if I could provide a pull request / patch for this (as far as I can see) trivial change.

(It seems like with the new migrations, supporting a pre-compiled pattern is not really relevant anymore (but could be kept still))

(I found this related commit:

Change History (10)

comment:1 by Daniel Hahler, 10 years ago

Since you can pass the flag(s) using (?i) etc, this can be easily worked around.

comment:2 by Sasha Romijn, 10 years ago

Easy pickings: set
Triage Stage: UnreviewedAccepted
Type: BugCleanup/optimization

So, with the latest comment, are you suggesting you no longer think patching this is useful?

Patching this makes sense to me: it can make code that uses RegexValidator a lot clearer when flags are passed separately, and the change required in Django is trivial.
For clarity: #21275 explains that the serialisation of validators is an intentional feature.

comment:3 by Dejan Noveski, 10 years ago

Owner: changed from nobody to Dejan Noveski
Status: newassigned

comment:4 by Dejan Noveski, 10 years ago

Cc: Dejan Noveski added
Has patch: set

comment:6 by Daniel Hahler, 10 years ago

Triage Stage: AcceptedReady for checkin
Type: Cleanup/optimizationBug

FWIW, the patch looks good to me.


comment:7 by Daniel Hahler, 10 years ago

Type: BugCleanup/optimization

comment:8 by Sasha Romijn, 10 years ago

Patch needs improvement: set

Left a comment on the patch. Minor issue in the docs.

comment:9 by Erik Romijn <erik@…>, 10 years ago

Resolution: fixed
Status: assignedclosed

In 4d0c5f61427a8e67552ee2d777fffbadc7aff3b2:

Fixed #22255 -- Added support for specifying re flags in RegexValidator

comment:10 by Sasha Romijn, 10 years ago

Patch needs improvement: unset

This was also backported to 1.7, thanks for the patch :)

Note: See TracTickets for help on using tickets.
Back to Top