Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#22216 closed Cleanup/optimization (fixed)

There is no mention of non_field_errors on the forms api page

Reported by: anonymous Owned by: nobody
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

There is no mention of non_field_errors on the forms api page.

This is in django 1.6, 1.5, 1.4, 1.3, 1.2 docs. Visit to https://docs.djangoproject.com/en/1.6/ref/forms/api/, and search for non_field_errors - there is no mention of that api entry point. It would be nice if there was.

This is related to the following tickets:

https://code.djangoproject.com/ticket/14023
https://code.djangoproject.com/ticket/13465

I see non_field errors is on the dev version of the docs. Good stuff. Do you update the older docs for requests like this?

Attachments (1)

22216.diff (3.6 KB) - added by Tim Graham 2 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 3 years ago by Baptiste Mispelon

Component: UncategorizedDocumentation
Easy pickings: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization
Version: 1.6master

Hi,

The mention of non_field_errors was made as part of commit f563c339ca2eed81706ab17726c79a6f00d7c553 which only applies to the dev version.

We usually backport documentation fixes to older versions of the doc (provided it's relevant and not too much hassle) but in this case, we can't really do that.

However, eventhough non_field_errors is now mentionned, I agree that it's lacking a proper reference like Form.errors has for example, so I'll accept this ticket.

If you provide a patch, I don't see any reason why it couldn't be applied to older versions of the doc as well.

Thanks.

Changed 2 years ago by Tim Graham

Attachment: 22216.diff added

comment:2 Changed 2 years ago by Tim Graham

Has patch: set

comment:3 Changed 2 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In d2f4553d705951ca8043d687f9493c559f494a0c:

Fixed #22216 -- Added Form.non_field_errors to form API doc.

comment:4 Changed 2 years ago by Tim Graham <timograham@…>

In 38679254bf2006c0b31bdb172802024836dac46c:

[1.7.x] Fixed #22216 -- Added Form.non_field_errors to form API doc.

Backport of d2f4553d705951ca8043d687f9493c559f494a0c from master

Note: See TracTickets for help on using tickets.
Back to Top