Add a flag to ErrorDict.as_json() to escape html
|Reported by:||timo||Owned by:||vedran|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
from Marc Tamlyn:
Some use cases for ErrorDict.as_json() are:
- AJAX requests to a form view where the client interprets the response and puts errors into the page (so HTML escaping would be useful)
- Building an API which handles JSON. In this case HTML escaping is plain wrong.
In the first case, it is trivial using jQuery to ensure the text is escaped - simply use $(el).text(errorText) rather than .html() and jQuery will escape the HTML for you. We should document that the as_json() method does not not escape the result and can even reference the relevant jQuery method as an example for how to do this client-side.
from Shai Berger:
We should also probably add a flag for HTML escaping -- it is useful for a very common use-case of the method, and we shouldn't assume jQuery or any client-side library. While this is less than totally clean (and that, in itself, is reason enough not to escape HTML by default), practicality beats purity -- and adding such a flag will result in more secure Django-based sites.
Change History (4)
comment:2 Changed 2 years ago by vedran
- Owner changed from nobody to vedran
- Status changed from new to assigned