Opened 16 months ago

Closed 15 months ago

Last modified 4 months ago

#21939 closed Cleanup/optimization (fixed)

Deprecate loading ssi/url tags from future

Reported by: timo Owned by: zsiciarz
Component: Template system Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In #18037, it was decided to add this to the deprecation timeline under 2.0: "ssi and url template tags will be removed from the future template tag library (used during the 1.3/1.4 deprecation period)."

At this time, it appears unlikely (from the discussion I've come across) that Django will have a "2.0" in the sense of a major backwards incompatible release in the foreseeable future. Thus, I think having this on the deprecation timeline may create some confusion. If we want to keep it, I think we should at least add some clarifying text as to what "2.0" means.

Change History (13)

comment:1 Changed 16 months ago by aaugustin

I think 2.0 is simply the version after 1.9. Unless someone says otherwise, this is going to happen ;-)

comment:2 Changed 16 months ago by claudep

We might also choose 2.0 as the Django version where we drop Python 2 support.

comment:3 Changed 16 months ago by aaugustin

There would be no 1.9 then ;-)

comment:4 Changed 16 months ago by jezdez

Looking back at the ticket I have to say, I think I still believed that a Django 2.0 would eventually be a API breaking release as Python 3. Now that we know how hostile that has been to Python I think we should reconsider this and use a proper deprecation roadmap.

I also would rather not use those poor template tags for creating a precedence of deciding what 2.0 means -- it's a much bigger discussion and shouldn't bound to bad decisions of the past. Let's move the deprecation into 1.9 and be done with it.

comment:5 Changed 16 months ago by timo

  • Component changed from Documentation to Template system
  • Easy pickings set
  • Summary changed from Reconsider "2.0" deprecation of ssi/url tags from future to Deprecate loading ssi/url tags from future
  • Triage Stage changed from Unreviewed to Accepted

@jezdez -- sounds good to me. Should be relatively "easy pickings" by following the deprecating a feature guide.

comment:6 Changed 15 months ago by zsiciarz

  • Owner changed from nobody to zsiciarz
  • Status changed from new to assigned

comment:7 Changed 15 months ago by zsiciarz

  • Owner zsiciarz deleted
  • Status changed from assigned to new

comment:8 Changed 15 months ago by zsiciarz

  • Owner set to zsiciarz
  • Status changed from new to assigned

comment:9 Changed 15 months ago by zsiciarz

The note at https://docs.djangoproject.com/en/dev/intro/tutorial03/#removing-hardcoded-urls-in-templates is mentioning Django < 1.5, is it worth keeping it?

comment:10 Changed 15 months ago by timo

We can remove that note. The latest version of the tutorial isn't designed to support multiple versions.

comment:11 Changed 15 months ago by zsiciarz

comment:12 Changed 15 months ago by Zbigniew Siciarz <antyqjon@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 74d4d58b62f3a68bf77b983bc8a475a130d1f95e:

Fixed #21939 -- Deprecated loading ssi/url tags from future.

comment:13 Changed 4 months ago by Tim Graham <timograham@…>

In bd93032191f96bc7086aa46b91b4177601c6fce9:

Removed ssi/url tags from future per deprecation timeline; refs #21939.

Note: See TracTickets for help on using tickets.
Back to Top