Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18037 closed Cleanup/optimization (fixed)

Switch the url and ssi template tags to the "future" behavior

Reported by: aaugustin Owned by: nobody
Component: Template system Version: master
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As explained in the deprecation timeline.

Attachments (2)

18037-1.diff (61.3 KB) - added by claudep 3 years ago.
Remove old-style url and ssi template tags
18037-2.diff (61.9 KB) - added by claudep 3 years ago.
Same patch with 2.0 deprecation note

Download all attachments as: .zip

Change History (10)

comment:1 Changed 3 years ago by aaugustin

  • Component changed from Uncategorized to Template system
  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Uncategorized to Cleanup/optimization
  • Version changed from 1.4 to SVN

comment:2 Changed 3 years ago by aaugustin

  • Severity changed from Normal to Release blocker

Changed 3 years ago by claudep

Remove old-style url and ssi template tags

comment:3 Changed 3 years ago by claudep

  • Has patch set

comment:4 Changed 3 years ago by ramiro

Patch is OK.

My only concern about which Id like to have a clear path is about the lifetime of the future template tag library, or more precisely the lifetime of the ssi and url template tags contained in it. Are we going to leave them there as do-nothing shims forever? Are we going to remove them now? Are we going to create a deprecation cycle for these kind of tags?

Last edited 3 years ago by ramiro (previous) (diff)

comment:5 Changed 3 years ago by claudep

Leaving them for ever might be problematic, should we need a new deprecation process in the future with these tags. Removing them right now doesn't seem a nice option, as it would break templates loading the future library in 1.5. The following patch adds a note to the 2.0 section of the deprecation timeline. The other viable option would be to start a new standard deprecation path for those two tags when loaded from the future library.

Changed 3 years ago by claudep

Same patch with 2.0 deprecation note

comment:6 Changed 3 years ago by jezdez

I'd be for leaving the future template tag library in place, including the shims for those template tags as it really was supposed to work like Python's __future__.

According to http://docs.python.org/library/__future__.html: "No feature description will ever be deleted from future"

So +1 for deprecating it in 2.0

comment:7 Changed 3 years ago by claudep

  • Resolution set to fixed
  • Status changed from new to closed

In [17934]:

Fixed #18037 -- Changed behaviour of url and ssi template tags to the new syntax, as per official deprecation timeline. Thanks Ramiro Morales and Jannis Leidel for the review.

comment:8 Changed 3 years ago by claudep

In [17935]:

Removed some leftover references to old-syntax ssi template tag tests. Refs #18037.

Note: See TracTickets for help on using tickets.
Back to Top