Opened 3 years ago

Closed 3 years ago

#18038 closed Cleanup/optimization (fixed)

Remove the 'supports_inactive_user' backwards-compatibility flag

Reported by: aaugustin Owned by: nobody
Component: contrib.auth Version: master
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As explained in the deprecation timeline.

Attachments (3)

18038-wip.patch (3.4 KB) - added by aaugustin 3 years ago.
18038-2.diff (8.2 KB) - added by claudep 3 years ago.
Tests included
18038-3.diff (8.2 KB) - added by claudep 3 years ago.
Added one sentence in the docs

Download all attachments as: .zip

Change History (9)

Changed 3 years ago by aaugustin

comment:1 Changed 3 years ago by aaugustin

  • Has patch set
  • Patch needs improvement set

Several backends defined in d.c.auth's test define supports_inactive_user = True; this isn't fixed in the patch I attached. Also, the docs could be improved.

comment:2 Changed 3 years ago by aaugustin

  • Severity changed from Normal to Release blocker

Changed 3 years ago by claudep

Tests included

comment:3 Changed 3 years ago by claudep

I didn't improve the docs, still.

Changed 3 years ago by claudep

Added one sentence in the docs

comment:4 Changed 3 years ago by claudep

  • Patch needs improvement unset

In the last patch, I only added:
"Do not forget to test for the is_active attribute of the user in your own
backend permission methods."

If Aymeric wanted to add more, I think we should then open a seperate ticket.

comment:5 Changed 3 years ago by ramiro

  • Triage Stage changed from Accepted to Ready for checkin

comment:6 Changed 3 years ago by claudep

  • Resolution set to fixed
  • Status changed from new to closed

In [17938]:

Fixed #18038 -- Removed the 'supports_inactive_user' backwards-compatibility flag. Thanks Aymeric Augustin for the initial patch and Ramiro Morales for the review.

Note: See TracTickets for help on using tickets.
Back to Top