Opened 13 years ago
Closed 13 years ago
#18038 closed Cleanup/optimization (fixed)
Remove the 'supports_inactive_user' backwards-compatibility flag
| Reported by: | Aymeric Augustin | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.auth | Version: | dev |
| Severity: | Release blocker | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
As explained in the deprecation timeline.
Attachments (3)
Change History (9)
by , 13 years ago
| Attachment: | 18038-wip.patch added |
|---|
comment:1 by , 13 years ago
| Has patch: | set |
|---|---|
| Patch needs improvement: | set |
comment:2 by , 13 years ago
| Severity: | Normal → Release blocker |
|---|
comment:4 by , 13 years ago
| Patch needs improvement: | unset |
|---|
In the last patch, I only added:
"Do not forget to test for the is_active attribute of the user in your own
backend permission methods."
If Aymeric wanted to add more, I think we should then open a seperate ticket.
comment:5 by , 13 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note:
See TracTickets
for help on using tickets.
Several backends defined in d.c.auth's test define
supports_inactive_user = True; this isn't fixed in the patch I attached. Also, the docs could be improved.