#21867 closed Cleanup/optimization (fixed)
AppStaticStorage is still using app_module.__file__
Reported by: | Aymeric Augustin | Owned by: | Carl Meyer |
---|---|---|---|
Component: | contrib.staticfiles | Version: | dev |
Severity: | Release blocker | Keywords: | app-loading |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
It should perhaps be updated to use app_config.path.
Reported here: https://code.djangoproject.com/ticket/21862#comment:5
Change History (6)
comment:1 by , 11 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 11 years ago
Has patch: | set |
---|
comment:3 by , 11 years ago
Severity: | Normal → Release blocker |
---|
If we take the risk of breaking things, let's take it only in one release.
comment:4 by , 11 years ago
Yeah, I think we should tread carefully and add this to a list of APIs that could be cleaned up in a future version. Whether we can actually get rid of AppStaticStorage right away, I'm not sure. Maybe check with sourcegraph if there are many uses out there? https://sourcegraph.com/search?q=AppStaticStorage
comment:5 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
Filed https://github.com/django/django/pull/2211 as a suggested fix for this.