Opened 3 years ago

Closed 3 years ago

#21866 closed Bug (fixed)

Static word "COMMIT"

Reported by: Wojciech Banaś Owned by: nobody
Component: Core (Management commands) Version: master
Severity: Normal Keywords:
Cc: Wojciech Banaś Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no

Description

In the file "django/core/managment/base.py" is:

self.stdout.write('\n' + self.style.SQL_KEYWORD("COMMIT;"))

and should be:

self.stdout.write(self.style.SQL_KEYWORD(connection.ops.end_transaction_sql()))

Change History (3)

comment:1 Changed 3 years ago by Wojciech Banaś

Cc: Wojciech Banaś added
Easy pickings: set
Has patch: set

comment:2 Changed 3 years ago by Tim Graham

Patch needs improvement: set
Triage Stage: UnreviewedAccepted
Version: 1.6master

As I commented on the PR, it should be against master, not 1.6.x and you should following the commit message guidelines so the ticket will automatically be closed when the patch is merged. Thanks!

comment:3 Changed 3 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In 8f2f48ecc9431c4d8959354a607fa559aa85dd99:

Fixed #21866 -- Replaced "COMMIT" in managmement command SQL with backend hook.

Note: See TracTickets for help on using tickets.
Back to Top