Opened 19 years ago
Closed 17 years ago
#2177 closed enhancement (invalid)
[Patch] Free Preview and Posted Templates for Comments App
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.comments | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Currently in trunk when someone uses the free comments app the included form will redirect to a comment preview however their is no default freepreview.html template to use so I've cleaned up the one DjangoProject uses and added i18n tags.
Attachments (5)
Change History (13)
by , 19 years ago
| Attachment: | free_preview.html added |
|---|
by , 19 years ago
| Attachment: | posted.html added |
|---|
comment:1 by , 19 years ago
| Summary: | Free Preview Template for Comments App → Free Preview and Posted Templates for Comments App |
|---|
comment:2 by , 19 years ago
The template file names are pretty non-uniform, as well. Currently, they are:
freeform.html
free_preview.html
freecomment_list.html
posted.html
Would it be worth it to break backward compatibility slightly and change them to the following?
freecomment_form.html
freecomment_preview.html
freecomment_list.html
freecomment_posted.html
comment:3 by , 19 years ago
| priority: | high → normal |
|---|---|
| Summary: | Free Preview and Posted Templates for Comments App → [Patch] Free Preview and Posted Templates for Comments App |
by , 19 years ago
| Attachment: | template1.zip added |
|---|
comment:4 by , 19 years ago
| Component: | Contrib apps → django.contrib.comments |
|---|
comment:5 by , 19 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:6 by , 19 years ago
| Has patch: | set |
|---|
comment:7 by , 17 years ago
| milestone: | 1.0 beta |
|---|
comment:8 by , 17 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
With the new comment system added in [8557], I'm closing all comment-related tickets since they're against an old system. Please open a new ticket for this issue if it still applies in the new system.
Changed to include Posted template as well since it's not included by default either.