Opened 9 years ago

Closed 7 years ago

#2177 closed enhancement (invalid)

[Patch] Free Preview and Posted Templates for Comments App

Reported by: kanashii@… Owned by: nobody
Component: contrib.comments Version:
Severity: normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Currently in trunk when someone uses the free comments app the included form will redirect to a comment preview however their is no default freepreview.html template to use so I've cleaned up the one DjangoProject uses and added i18n tags.

Attachments (5)

free_preview.html (1.4 KB) - added by kanashii@… 9 years ago.
posted.html (361 bytes) - added by kanashii@… 9 years ago.
free_preview.2.html (1.4 KB) - added by kanashii@… 9 years ago.
missed a translation
django.po (53.5 KB) - added by coulix 9 years ago.
adding french translation for "Post comment"
template1.zip (1.5 KB) - added by anonymous 9 years ago.

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by kanashii@…

Changed 9 years ago by kanashii@…

comment:1 Changed 9 years ago by kanashii@…

  • Summary changed from Free Preview Template for Comments App to Free Preview and Posted Templates for Comments App

Changed to include Posted template as well since it's not included by default either.

Changed 9 years ago by kanashii@…

missed a translation

Changed 9 years ago by coulix

adding french translation for "Post comment"

comment:2 Changed 9 years ago by Tyson

The template file names are pretty non-uniform, as well. Currently, they are:

freeform.html
free_preview.html
freecomment_list.html
posted.html

Would it be worth it to break backward compatibility slightly and change them to the following?

freecomment_form.html
freecomment_preview.html
freecomment_list.html
freecomment_posted.html

comment:3 Changed 9 years ago by anonymous

  • priority changed from high to normal
  • Summary changed from Free Preview and Posted Templates for Comments App to [Patch] Free Preview and Posted Templates for Comments App

Changed 9 years ago by anonymous

comment:4 Changed 9 years ago by adrian

  • Component changed from Contrib apps to django.contrib.comments

comment:5 Changed 8 years ago by Simon G. <dev@…>

  • Triage Stage changed from Unreviewed to Accepted

comment:6 Changed 8 years ago by Simon G. <dev@…>

  • Has patch set

comment:7 Changed 7 years ago by jacob

  • milestone 1.0 beta deleted

comment:8 Changed 7 years ago by jacob

  • Resolution set to invalid
  • Status changed from new to closed

With the new comment system added in [8557], I'm closing all comment-related tickets since they're against an old system. Please open a new ticket for this issue if it still applies in the new system.

Note: See TracTickets for help on using tickets.
Back to Top