Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#21728 closed Cleanup/optimization (fixed)

Writing your first patch for Django documentation points to the wrong directory

Reported by: Tianyi Wang Owned by: Tianyi Wang
Component: Documentation Version: 1.6
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In the ​Writing your first patch for Django documentation's ​writing-some-tests-for-ticket-17549 section, it says "Navigate to Django’s tests/admin_widgets/ folder and open the tests.py file.". It is correct directory for Django 1.6, but it asks reader to do git checkout 39f5bc7fc3a4bb43ed8a1358b17fe0521a1a63ac in the ​section above. So this results the correct directory for tests.py to be tests/regressiontests/admin_widgets/. Also in the ​generating-a-patch-for-your-changes section, it should be using the directory metioned.

Change History (4)

comment:1 by Tim Graham, 13 years ago

Easy pickings: set
Triage Stage: Unreviewed → Accepted

Yep, this was inadvertently removed in 3bbcec0aba81b626a26c19736dbac49999007d6c.

comment:2 by Tianyi Wang, 13 years ago

Owner: changed from nobody to Tianyi Wang
Status: new → assigned

comment:3 by Tim Graham <timograham@…>, 13 years ago

Resolution: → fixed
Status: assigned → closed

In e6800ea136aaa882682dbb7dc54423c5f002b551:

Fixed #21728 -- Corrected an inadvertent path change in docs/intro/contributing.txt.

comment:4 by Tim Graham <timograham@…>, 13 years ago

In 7a4d2b8e3d785f518ceec74c7ead862b84715618:

[1.6.x] Fixed #21728 -- Corrected an inadvertent path change in docs/intro/contributing.txt.

Backport of e6800ea136 from master

Note: See TracTickets for help on using tickets.
Back to Top