Documentation for REQUIRED_FIELDS on custom users is ambiguous

[Russell Keith-Magee]

The ​documentation for the REQUIRED_FIELDS definition on a custom user model describes what fields must be included in required fields. It includes a note that says that USERNAME_FIELD should not be included in REQUIRED_FIELDS.

However, it doesn't say anything about password - which is a required field, and would otherwise meet the requirements of the REQUIRED_FIELDS definition. The note should be expanded (and the general definition clarified) to specifically exclude password.

This doesn't actually cause any problems -- it just means that the createsuperuser command asks for the password three times, instead of two, but it is confusing behaviour.

[Russell Keith-Magee]

FYI - this was reported by 项楠 on the ​users mailing list.

[Tim Graham]

Does the patch look ok?

[Tim Graham <timograham@…>]

In 6f06c749b73abea84cd61a7bcfd1cc9732fbefe5:

Fixed #21726 -- Clarified that password should not be included in REQUIRED_FIELDS.

Thanks russellm for the report.

[Tim Graham <timograham@…>]

In f7c2852f30fd5fe6980d6983725a41e64c6d2c53:

[1.6.x] Fixed #21726 -- Clarified that password should not be included in REQUIRED_FIELDS.

Thanks russellm for the report.

Backport of 6f06c749b7 from master

[Tim Graham <timograham@…>]

In ebed0149505c9689650442ddc4e9a3efbf3579be:

[1.5.x] Fixed #21726 -- Clarified that password should not be included in REQUIRED_FIELDS.

Thanks russellm for the report.

Backport of 6f06c749b7 from master