Opened 17 months ago

Closed 12 months ago

Last modified 12 months ago

#21685 closed Cleanup/optimization (fixed)

admin_doc/model_index.html should use application names

Reported by: aaugustin Owned by: mrshu
Component: contrib.admindocs Version: master
Severity: Normal Keywords: app-loading
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Currently, the template uses app_label|capfirst to display the application name.

Since the app loading refactor, app_config.verbose_name provides a customizable application name.

Attachments (1)

admindocs.tar.gz (99.8 KB) - added by alvaro@… 14 months ago.
path with some solutions.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 17 months ago by aaugustin

  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 17 months ago by aaugustin

  • Easy pickings set

comment:3 Changed 16 months ago by aaugustin

Anyone wants to provide a patch for this? I don't expect it to be particularly hard.

It's low priority for me because it's peripheral to app-loading.

Tests are appreciated but not absolutely required given admindocs' relatively low test coverage.

comment:4 Changed 16 months ago by mrshu

  • Owner changed from nobody to mrshu
  • Status changed from new to assigned

I'd like to try to create a patch for this but I could not find app_config being used anywhere.

Could you please elaborate more on how to you imagine this patch to look like?

Thanks!

comment:5 Changed 16 months ago by aaugustin

Here's the commit that did that change in django.contrib.admin:
https://github.com/django/django/commit/ba60fcbcf7645afd82f3135ecb56562f8a9c9824

This ticket is essentially about doing the same thing in django.contrib.admindocs.

The appropriate app_config object must be added to the template context.

Changed 14 months ago by alvaro@…

path with some solutions.

comment:6 Changed 12 months ago by Claude Paroz <claude@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 4cf82e5bcf87e0d5419d941c2ef7ec8855801319:

Fixed #21685 -- Displayed app verbose name in admindocs model index

comment:7 Changed 12 months ago by Claude Paroz <claude@…>

In 9d0ebceb324ebb13b6d859153f95b2ef0c7c326b:

[1.7.x] Fixed #21685 -- Displayed app verbose name in admindocs model index

Backport of 4cf82e5bcf from master.

Note: See TracTickets for help on using tickets.
Back to Top