Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#21649 closed New feature (fixed)

Add session signing based on the value of the user's password

Reported by: Tim Graham Owned by: Tim Graham
Component: contrib.auth Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Add another value ('_auth_user_hash', '<some hash stuff>') based on the HMAC of the user's password hash to session verification. This will have the benefit of allowing a user to log out their other sessions by changing the password. Of course, it should not log out the current session.

Change History (9)

comment:1 by Tim Graham, 11 years ago

Has patch: set

PR is up for review.

One thing I'd like feedback on is whether we should try to make this more backwards-compatible. Currently: "As a side effect of this change, users will be logged out when upgrading from an older version of Django."

comment:2 by Paul McMillan, 11 years ago

I think in the past we've done work to preserve sessions across version upgrades. This of course has the downside of making the full benefit of the patch take an extra version to manifest. I personally don't mind sessions going away during upgrade, but I believe that some users of Django may not be comfortable with that.

I'd defer to Jacob or Luke or another conservative core dev. The upgrade code path shouldn't be too complex in this case.

comment:3 by Tim Graham, 11 years ago

Patch needs improvement: set

Florian and Shai were both against losing sessions for this change. Shai suggested have a separate middleware for session signing & verification so that users who don't want this behavior can opt-out. I'll look into that approach.

comment:4 by Tim Graham, 11 years ago

Patch needs improvement: unset

Here's an updated PR that uses the middleware approach suggested above.

comment:5 by Aymeric Augustin, 11 years ago

Triage Stage: AcceptedReady for checkin

comment:6 by Tim Graham <timograham@…>, 11 years ago

Resolution: fixed
Status: newclosed

In fd23c06023a0585ee743c0752dc94da66694cf63:

Fixed #21649 -- Added optional invalidation of sessions when user password changes.

Thanks Paul McMillan, Aymeric Augustin, and Erik Romijn for reviews.

comment:7 by Tim Graham <timograham@…>, 11 years ago

In 5891fd3f89337fc190cf671575407233440d2736:

[1.7.x] Fixed #21649 -- Added optional invalidation of sessions when user password changes.

Thanks Paul McMillan, Aymeric Augustin, and Erik Romijn for reviews.

Backport of fd23c06023 from master

comment:8 by Tim Graham <timograham@…>, 11 years ago

In 11e30b684d1a74bf7cc3b3bd22c0ffbdaa28f0a0:

Fixed a KeyError on login with legacy sessions; refs #21649.

Thanks Loic for the report.

comment:9 by Tim Graham <timograham@…>, 11 years ago

In 548acd77fd6356073ad4fa514c3d61f6589da43b:

[1.7.x] Fixed a KeyError on login with legacy sessions; refs #21649.

Thanks Loic for the report.

Backport of 11e30b684d from master

Note: See TracTickets for help on using tickets.
Back to Top