SingleObjectMixin raises ObjectDoesNotExist, rather than a more specific subclass

[Keryn Knight <django@…>]

When calling get_object for something which inherits from SingleObjectMixin, the exception caught is ​ObjectDoesNotExist, when as far as I can tell, based on the Http404 ​raised, the more specific form of queryset.model.DoesNotExist could be used instead.

I can't see any docs or comments as to a historic (or current) reason it may be catching the generic version (perhaps there are scenarios where the Model's DoesNotExist is not available yet?), and there are probably no implications by casting a wider net than necessary, but I'm opening the ticket anyway in case as a possible cleanup worth doing.

[Marc Tamlyn]

I don't see any reason why we would need the less specific exception.

[pjrharley]

Submitted PR here:

​https://github.com/django/django/pull/2077

[Baptiste Mispelon]

Hi,

I added some comments on the PR.
Once those are addressed, you can remove the patch needs improvement flag on the ticket.

Thanks.

[pjrharley]

Thanks, new commit added to the PR and some comments over there.

[Baptiste Mispelon <bmispelon@…>]

In cdd6617da679e19059907979b03c4ef7b15691e6:

Fixed #21619 -- Made SingleObjectMixin.get_object catch a more precise exception.

Thanks to Keryn Knight for the report.