Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21618 closed Cleanup/optimization (fixed)

GeoDjango OpenLayers.js admin include does not work over HTTPS

Reported by: kz26 Owned by: nobody
Component: GIS Version: 1.6
Severity: Normal Keywords: geodjango openlayers gis
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

When attempting to access a GeoDjango-enabled admin page over HTTPS, the GeometryField widgets do not load because the page attempts to load http://openlayers.org/api/2.11/OpenLayers.js over plain HTTP, which is blocked by the Firefox security policy.

Attachments (2)

21618-1.diff (1.6 KB) - added by Claude Paroz 3 years ago.
Documentation complement
21618-2.diff (1.7 KB) - added by Tim Graham 3 years ago.
minor edits

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 years ago by Claude Paroz

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted
Type: BugCleanup/optimization

See https://github.com/openlayers/openlayers/issues/1025

The fix for this ticket is to explain in the documentation that you should subclass the widget and specify your own URL (either self or cdn-hosted). Same for OpenStreetMap.js.

comment:2 Changed 3 years ago by Claude Paroz

Changed 3 years ago by Claude Paroz

Attachment: 21618-1.diff added

Documentation complement

comment:3 Changed 3 years ago by Claude Paroz

Has patch: set
Patch needs improvement: set

The above patch needs at least language review.

Changed 3 years ago by Tim Graham

Attachment: 21618-2.diff added

minor edits

comment:4 Changed 3 years ago by Tim Graham

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:5 Changed 3 years ago by Claude Paroz <claude@…>

Resolution: fixed
Status: newclosed

In b7a7baa55471e67b98d509cddf2f0994f7ce786f:

Fixed #21618 -- Added hints about openlayers.js hosting

Thanks kz26 for the report and Tim Graham for the excellent
review.

comment:6 Changed 3 years ago by Claude Paroz <claude@…>

In 2d08390d70007236e083183d78a4435d249c5aa8:

[1.6.x] Fixed #21618 -- Added hints about openlayers.js hosting

Thanks kz26 for the report and Tim Graham for the excellent
review.
Backport of b7a7baa554 from master.

Note: See TracTickets for help on using tickets.
Back to Top