Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#21560 closed Bug (fixed)

missing 'slug' field in example code

Reported by: jfindlay@… Owned by: merb
Component: Documentation Version: 1.6
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

https://docs.djangoproject.com/en/1.6/topics/forms/modelforms/#overriding-the-default-fields

Consider the 2nd to last code quotation (before the lengthy 'Note') in this section. Both the text and the code block refer to and imply a 'slug' field in the fields list of the Meta class. The last code block, however does not omit it.

Change History (7)

comment:1 Changed 19 months ago by jfindlay@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Or, maybe it will work the way it is written. I'm confused.

comment:2 Changed 19 months ago by timo

  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Uncategorized to Bug

It was an accidental omission.

comment:3 Changed 19 months ago by merb

  • Owner changed from nobody to merb
  • Status changed from new to assigned

comment:4 Changed 19 months ago by merb

  • Has patch set

I updated the documentation and added a pull request: https://github.com/django/django/pull/2058

comment:5 Changed 19 months ago by Christian Schmitt <c.schmitt@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 744aac6dace325752e3b1c7c8af64a7bc655186f:

Fixed #21560 -- missing 'slug' field in example code
I updated the documentation, that the modelform now includes the 'slug' field.

comment:6 Changed 19 months ago by Claude Paroz <claude@…>

In 0873200e7f61315ad375061a3dc6d37b514ff985:

Merge pull request #2058 from c-schmitt/fixes_21560

Fixed #21560 -- missing 'slug' field in example code

comment:7 Changed 19 months ago by Tim Graham <timograham@…>

In d6d700fc6d5c32b86989a51a8a721e09ca26f1f4:

[1.6.x] Fixed #21560 -- Added missing 'slug' field in example code.

Backport of 744aac6dac from master

Note: See TracTickets for help on using tickets.
Back to Top