Opened 11 years ago

Closed 11 years ago

#21543 closed Cleanup/optimization (fixed)

Unused base_dir attribute in StaticFilesHandler

Reported by: Krzysztof Jurewicz Owned by: Krzysztof Jurewicz
Component: contrib.staticfiles Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In django.contrib.staticfiles.handlers.StaticFilesHandler class, the __init__ function sets the base_dir the attribute. This attribute seems to be unused anywhere in the codebase, so it can be removed.

Change History (2)

comment:1 by Krzysztof Jurewicz, 11 years ago

Has patch: set

I’ve created a pull request: ​https://github.com/django/django/pull/2014

comment:2 by Tim Graham <timograham@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In b8be3055f1d81ee956ea1572c48cc352b63099db:

Fixed #21543 -- Removed base_dir attribute in StaticFilesHandler.

This code seems to be an artifact of AdminMediaHandler removed in [5c53e30607].

Note: See TracTickets for help on using tickets.
Back to Top