Code

Opened 5 months ago

Closed 4 months ago

#21406 closed Bug (fixed)

blocktrans trimmed mixes up po-file source line numbers

Reported by: bouke Owned by: bouke
Component: Internationalization Version: master
Severity: Normal Keywords:
Cc: bouke@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Currently when makemessages generates a po-file from a template, it uses an intermediate format as templates cannot be fed into gettext. This intermediate Python file follows the same structure as the original template file, such that the source line numbers match up. However with blocktrans new trimmed option, the intermediate format is not adjusted and as a result the line numbers of translations following after that tag are mixed up.

Attachments (1)

21406-proof.diff (1.1 KB) - added by bouke 5 months ago.

Download all attachments as: .zip

Change History (5)

Changed 5 months ago by bouke

comment:1 Changed 5 months ago by bouke

  • Cc bouke@… added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 5 months ago by bmispelon

  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Uncategorized to Bug

comment:3 Changed 5 months ago by bouke

  • Has patch set
  • Owner changed from nobody to bouke
  • Status changed from new to assigned

comment:4 Changed 4 months ago by ramiro

  • Resolution set to fixed
  • Status changed from assigned to closed

In 91c38ce4b236e6eeb5f6f636250df7316fa766bd:

Fixed 21406 -- Made blocktrans 'trimmed' option preserve line numbers.

Thanks Bouke Haarsma for report, fix and initial patch.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.