#2129 closed defect (invalid)
the validate() method shouldn't ignore maxlength
Reported by: | Owned by: | Adrian Holovaty | |
---|---|---|---|
Component: | Validators | Version: | dev |
Severity: | normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The validate() method of a model does not complain when exceeding the maxlength of a CharField.
There should be an error in the returned dictionary (e.g. "Ensure your text is less than 75 characters.")
In the following example someone could add an invalid e-mail-address without getting a validation error:
>>> import django.contrib.auth.models as auth >>> u = auth.User.objects.get(pk=1) >>> u.email = 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx@xx.xx' >>> u.validate() {} >>> u.save() /usr/lib/python2.3/site-packages/django/db/backends/mysql/base.py:35: Warning: Rows matched: 1 Changed: 1 Warnings: 1 return self.cursor.execute(sql, params) >>> u.validate() {} >>> u = auth.User.objects.get(pk=1) >>> u.email 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx' >>> u.validate() {'email': ['Enter a valid e-mail address.']} >>>
Note:
See TracTickets
for help on using tickets.
validate()
isn't meant to be public yet, and it's not finished yet, so I'm closing this.