Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#2129 closed defect (invalid)

the validate() method shouldn't ignore maxlength

Reported by: tom@… Owned by: Adrian Holovaty
Component: Validators Version: master
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


The validate() method of a model does not complain when exceeding the maxlength of a CharField.
There should be an error in the returned dictionary (e.g. "Ensure your text is less than 75 characters.")

In the following example someone could add an invalid e-mail-address without getting a validation error:

>>> import django.contrib.auth.models as auth
>>> u = auth.User.objects.get(pk=1)
>>> = 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx@xx.xx'
>>> u.validate()
/usr/lib/python2.3/site-packages/django/db/backends/mysql/ Warning: Rows matched: 1  Changed: 1  Warnings: 1
  return self.cursor.execute(sql, params)
>>> u.validate()
>>> u = auth.User.objects.get(pk=1)
>>> u.validate()
{'email': ['Enter a valid e-mail address.']}

Change History (1)

comment:1 Changed 13 years ago by Adrian Holovaty

Resolution: invalid
Status: newclosed

validate() isn't meant to be public yet, and it's not finished yet, so I'm closing this.

Note: See TracTickets for help on using tickets.
Back to Top