Opened 10 years ago
Closed 9 years ago
#21201 closed New feature (fixed)
Let ClearableFileInput work with other fields
| Reported by: | Vlastimil Zíma | Owned by: | Vlastimil Zíma |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Daniele Procida | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
ClearableFileInput is very useful widget, problem is that it can only be used with FileField as it only expects FieldFile as an initial value.
I propose a decomposition (see patch) which allows easy modification to use this widget with other fields.
Example: File input is used over data which are stored in database.
This problem is remotely connected with #15667 which may (or may not) solve this issue.
Attachments (1)
Change History (10)
Changed 10 years ago by
| Attachment: | clearable-file-input.patch added |
|---|
comment:1 Changed 10 years ago by
| Cc: | Daniele Procida added |
|---|---|
| Needs tests: | set |
| Triage Stage: | Unreviewed → Accepted |
comment:2 follow-up: 3 Changed 10 years ago by
| Needs documentation: | set |
|---|
comment:3 Changed 10 years ago by
comment:4 Changed 10 years ago by
docs/forms/ref/widgets.txt documents ClearableFileInput, but not the internals; I don't see any particular need to document internals of widgets. Perhaps an example of usage would be helpful.
comment:5 Changed 10 years ago by
This patch does change the behaviour of the widget, so we will need to understand any backwards-compatibility implications of it.
comment:6 Changed 10 years ago by
| Needs documentation: | unset |
|---|---|
| Needs tests: | unset |
| Owner: | changed from nobody to Vlastimil Zíma |
| Status: | new → assigned |
I have updated a patch and created pull request https://github.com/django/django/pull/1807
comment:7 Changed 9 years ago by
| Patch needs improvement: | set |
|---|
I left comments for improvement on the PR. Please uncheck "Patch needs improvement" when you update it, thanks.
comment:8 Changed 9 years ago by
| Patch needs improvement: | unset |
|---|
Patch rebased on master and updated.
comment:9 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Replying to EvilDMP:
Do you have in mind any particular changes in documentation beside note in changelog? Current documentation does not describe these internals of the widget.