Opened 3 years ago

Closed 2 years ago

#21201 closed New feature (fixed)

Let ClearableFileInput work with other fields

Reported by: vzima Owned by: vzima
Component: Forms Version: master
Severity: Normal Keywords:
Cc: EvilDMP Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


ClearableFileInput is very useful widget, problem is that it can only be used with FileField as it only expects FieldFile as an initial value.

I propose a decomposition (see patch) which allows easy modification to use this widget with other fields.

Example: File input is used over data which are stored in database.

This problem is remotely connected with #15667 which may (or may not) solve this issue.

Attachments (1)

clearable-file-input.patch (2.6 KB) - added by vzima 3 years ago.

Download all attachments as: .zip

Change History (10)

Changed 3 years ago by vzima

comment:1 Changed 3 years ago by EvilDMP

  • Cc EvilDMP added
  • Needs documentation unset
  • Needs tests set
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 follow-up: Changed 3 years ago by EvilDMP

  • Needs documentation set

comment:3 in reply to: ↑ 2 Changed 3 years ago by vzima

Replying to EvilDMP:
Do you have in mind any particular changes in documentation beside note in changelog? Current documentation does not describe these internals of the widget.

comment:4 Changed 3 years ago by EvilDMP

docs/forms/ref/widgets.txt documents ClearableFileInput, but not the internals; I don't see any particular need to document internals of widgets. Perhaps an example of usage would be helpful.

comment:5 Changed 3 years ago by EvilDMP

This patch does change the behaviour of the widget, so we will need to understand any backwards-compatibility implications of it.

comment:6 Changed 3 years ago by vzima

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to vzima
  • Status changed from new to assigned

I have updated a patch and created pull request

comment:7 Changed 2 years ago by timgraham

  • Patch needs improvement set

I left comments for improvement on the PR. Please uncheck "Patch needs improvement" when you update it, thanks.

comment:8 Changed 2 years ago by vzima

  • Patch needs improvement unset

Patch rebased on master and updated.

comment:9 Changed 2 years ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In e622caaa857e74cef4fe7757b6e5b802af814788:

Fixed #21201 -- Improved customization of ClearableFileInput.

Note: See TracTickets for help on using tickets.
Back to Top