Opened 19 months ago

Last modified 18 months ago

#21135 new New feature

Admin: Support for editing OneToOne related models in RELATED model

Reported by: jonash Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: jonas-django@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Consider these models:

class Person(models.Model):
  address = models.OneToOneField("Address")

class Organization(models.Model):
  address = models.OneToOneField("Address")

class Building(models.Model):
  address = models.OneToOneField("Address")

Currently it's not possible to have a different ModelAdmin for each of the above models because the ModelAdmin.inlines property works a *reversed* manner.

Using the new feature would look like this (same AddressAdmin for every model)

class AddressAdmin(admin.TabularInline):
  model = Address

class PersonAdmin(admin.ModelAdmin):
  inlines = [AddressAdmin]

class OrganizationAdmin(admin.ModelAdmin):
  inlines = [AddressAdmin]

class BuildingAdmin(admin.ModelAdmin):
  inlines = [AddressAdmin]

or even like this (different AddressAdmin)

class PersonAddressAdmin(admin.TabularInline):
  model = Address

class OrganizationAddressAdmin(admin.TabularInline):
  model = Address

class BuildingAddressAdmin(admin.TabularInline):
  model = Address

class PersonAdmin(admin.ModelAdmin):
  inlines = [PersonAddressAdmin]

class OrganizationAdmin(admin.ModelAdmin):
  inlines = [OrganizationAddressAdmin]

class BuildingAdmin(admin.ModelAdmin):
  inlines = [BuildingAddressAdmin]

Change History (2)

comment:1 Changed 19 months ago by jonash

  • Cc jonas-django@… added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 18 months ago by timo

  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from 1.5 to master

A better solution may be to use model inheritance and proxy models to achieve what you are trying to accomplish.

Here's what Malcolm had to say in an old thread on django-users:

Maybe you could knock up a patch to make this work and maybe it's
worthwhile (I don't really have a strong opinion either way, beyond
thinking that there's really no end to people twisting the admin
interface beyond intended usage and perhaps the should re-evaluate their
use-cases). This is "scratch your own itch" territory, I suspect.

I agree with the above.

I also found some possible code on djangosnipppets. Tentatively accepting the ticket.

Note: See TracTickets for help on using tickets.
Back to Top