Opened 11 years ago
Closed 10 years ago
#21051 closed Cleanup/optimization (wontfix)
Move cookie settings from standalone values to dictionaries
| Reported by: | Ramiro Morales | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Normal | Keywords: | cookie cookis csrf sesssion language |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
This could help with #15318 and other efforts to expand configurability of existing cookie-related settings.
See https://github.com/django/django/pull/1554 for the patch.
Change History (3)
comment:1 by , 11 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 11 years ago
| Patch needs improvement: | set |
|---|
comment:3 by , 10 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
The described limitations seem unlikely fixable with urrent implementation of settings infrastructure. Closing for now.
Note:
See TracTickets
for help on using tickets.
After discussion with Ramiro on IRC, we're not sure if we should move forward with this. Using a dictionary has the problem that default settings from
django/conf/global_settings.pywould be lost if only overriding part of theSESSION_COOKIEdictionary. I proposed the possibility of adding a shim to the settings setter to merge the two dictionaries, but I'm not sure if this is feasible or worth it.Marking as "patch needs improvement", but leaving it up to Ramiro as to whether we should move forward or won't fix.