Opened 5 years ago

Closed 4 years ago

#21051 closed Cleanup/optimization (wontfix)

Move cookie settings from standalone values to dictionaries

Reported by: Ramiro Morales Owned by: nobody
Component: Core (Other) Version: master
Severity: Normal Keywords: cookie cookis csrf sesssion language
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no


This could help with #15318 and other efforts to expand configurability of existing cookie-related settings.

See for the patch.

Change History (3)

comment:1 Changed 5 years ago by Tim Graham

Triage Stage: UnreviewedAccepted

comment:2 Changed 5 years ago by Tim Graham

Patch needs improvement: set

After discussion with Ramiro on IRC, we're not sure if we should move forward with this. Using a dictionary has the problem that default settings from django/conf/ would be lost if only overriding part of the SESSION_COOKIE dictionary. I proposed the possibility of adding a shim to the settings setter to merge the two dictionaries, but I'm not sure if this is feasible or worth it.

Marking as "patch needs improvement", but leaving it up to Ramiro as to whether we should move forward or won't fix.

comment:3 Changed 4 years ago by Ramiro Morales

Resolution: wontfix
Status: newclosed

The described limitations seem unlikely fixable with urrent implementation of settings infrastructure. Closing for now.

Note: See TracTickets for help on using tickets.
Back to Top