#21006 closed Cleanup/optimization (fixed)
Add an example of the formset argument for inlineformset_factory
Reported by: | Owned by: | Tianyi Wang | |
---|---|---|---|
Component: | Documentation | Version: | 1.5 |
Severity: | Normal | Keywords: | afraid-to-commit |
Cc: | treysta@…, Daniele Procida | Triage Stage: | Accepted |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
https://docs.djangoproject.com/en/1.5/topics/forms/modelforms/#overriding-clean-on-an-inlineformset
It looks like there is a somewhat relevant piece of information missing from this section. It leaves out the fact that you also must specify which formset to use when creating your inlineformset in the view:
Currently:
"See Overriding clean() on a ModelFormSet, but subclass BaseInlineFormSet rather than BaseModelFormSet."
Suggestion:
"See Overriding clean() on a ModelFormSet, but subclass BaseInlineFormSet rather than BaseModelFormSet. You must also specify which formset to use when creating your inlineformset in your view:"
>>> from django.forms.models import inlineformset_factory >>> BookFormSet = inlineformset_factory(Author, Book, formset= MyInlineFormSet) >>> author = Author.objects.get(name=u'Mike Royko') >>> formset = BookFormSet(instance=author)
Change History (12)
comment:1 by , 11 years ago
Description: | modified (diff) |
---|---|
Summary: | Overriding clean() on an InlineFormSet → Add an example of the formset argument for inlineformset_factory |
Triage Stage: | Unreviewed → Accepted |
Type: | Uncategorized → Cleanup/optimization |
comment:2 by , 11 years ago
Cc: | added |
---|---|
Keywords: | afraid-to-commit added |
comment:3 by , 11 years ago
I've marked this ticket as especially suitable for first-time committers or people following the Don't be afraid to commit tutorial. If you're tackling this ticket, please don't hesitate to ask me for guidance if you'd like any, either here or on the Django IRC channels, where I can be found as EvilDMP.
comment:4 by , 11 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:6 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
There's an example for
modelformset_factory
that uses theformset
argument and while you might be able to infer a similar technique will work forinlineformset_factory
since the docs say "Inline formsets is a small abstraction layer on top of model formsets", I agree an example could be helpful. I'm not sure it should be specific to the "Overriding clean()" section though, since theformset
argument is useful for other cases as well.If you could offer a patch, I'll be happy to review and commit it. Thanks!