Opened 2 years ago

Closed 2 years ago

#21005 closed Bug (fixed)

Schema tests are language-dependant

Reported by: claudep Owned by: Claude Paroz <claude@…>
Component: Migrations Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In the new schema tests, there is a check about the content of message errors in SchemaTests.delete_tables. Some databases are returning translated error messages, so this is too fragile. An alternative would be to test if the table exists before trying to delete it.

Attachments (1)

21005-1.2.diff (2.4 KB) - added by claudep 2 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 2 years ago by charettes

  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 2 years ago by claudep

  • Has patch set

Changed 2 years ago by claudep

comment:3 Changed 2 years ago by charettes

  • Triage Stage changed from Accepted to Ready for checkin

Tests pass and the new approach is way less convoluted.

comment:4 Changed 2 years ago by Claude Paroz <claude@…>

  • Owner set to Claude Paroz <claude@…>
  • Resolution set to fixed
  • Status changed from new to closed

In b04f8ddbaa57daaefee9eacbab1eaad437d8ff0a:

Fixed #21005 -- Made schema tests language-independent

Thanks Simon Charette for the review.

Note: See TracTickets for help on using tickets.
Back to Top