Opened 11 years ago

Closed 11 years ago

#21005 closed Bug (fixed)

Schema tests are language-dependant

Reported by: Claude Paroz Owned by: Claude Paroz <claude@…>
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In the new schema tests, there is a check about the content of message errors in SchemaTests.delete_tables. Some databases are returning translated error messages, so this is too fragile. An alternative would be to test if the table exists before trying to delete it.

Attachments (1)

21005-1.2.diff​ (2.4 KB ) - added by Claude Paroz 11 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by Simon Charette, 11 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Claude Paroz, 11 years ago

Has patch: set

by Claude Paroz, 11 years ago

Attachment: 21005-1.2.diff​ added

comment:3 by Simon Charette, 11 years ago

Triage Stage: Accepted → Ready for checkin

Tests pass and the new approach is way less convoluted.

comment:4 by Claude Paroz <claude@…>, 11 years ago

Owner: set to Claude Paroz <claude@…>
Resolution: → fixed
Status: new → closed

In b04f8ddbaa57daaefee9eacbab1eaad437d8ff0a:

Fixed #21005 -- Made schema tests language-independent

Thanks Simon Charette for the review.

Note: See TracTickets for help on using tickets.
Back to Top