Code

#20907 closed Bug (fixed)

Test failure on Oracle: test_attribute_name_not_python_keyword

Reported by: shai Owned by: shai
Component: Database layer (models, ORM) Version: 1.4
Severity: Normal Keywords: oracle
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Running updated stable/1.4.x on Oracle:

FAIL: test_attribute_name_not_python_keyword (regressiontests.inspectdb.tests.InspectDBTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/django/django/django/test/testcases.py", line 861, in skip_wrapper
    return test_func(*args, **kwargs)
  File "/home/django/django/tests/regressiontests/inspectdb/tests.py", line 17, in test_attribute_name_not_python_keyword
    out.getvalue())
AssertionError: 'people_pk = models.ForeignKey(InspectdbPeople, primary_key=True)' not found in 
                     u"# This is an auto-generated Django...
                     ...people_pk = models.ForeignKey(InspectdbPeople, unique=True)\n...

Attachments (0)

Change History (3)

comment:1 Changed 11 months ago by timo

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

This test failure was fixed by a18e43c5bb8cb7c82c84ca1b42d847a62ac9f077 -- I'm not sure we want to backport it to 1.4.x as it's a non-trivial change? It does seem to cherry-pick cleanly, but I haven't tried running the entire test suite.

comment:2 Changed 11 months ago by shai

  • Owner changed from nobody to shai
  • Status changed from new to assigned

Cherry-picking the whole commit just for the Oracle problem seems wrong, as it includes fixes for all the backends.

I'll see about applying just the Oracle change.

comment:3 Changed 11 months ago by Shai Berger <shai@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7826824aef42097e265ad5132bfbff4c64762dd7:

[1.4.x] Fixed #20907 - Test failure on Oracle

Backport of the Oracle-specific part of commit a18e43c5bb8cb7c82
from master. This commit made get_indexes more consistent across
backends.

Thanks Tim Graham for pointer to the commit, akaariai and ikelly
for the original commit.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.