Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#20855 closed Bug (fixed)

Missing documentation of current_app and extra_context parameters on django.contrib.auth views

Reported by: jmichalicek Owned by: jmichalicek
Component: Documentation Version: master
Severity: Normal Keywords: documentation, auth, extra_context, current_app
Cc: timograham@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The documentation for the current_app and extra_context parameters added to django.contrib.auth views on commits [07705ca1] and [cc64fb5c] is missing.

I assume this should be added for all versions where the parameters exist (probably 1.3-ish and up) on the master branch. Do I also need to update version specific branches?

Change History (6)

comment:1 Changed 2 years ago by timo

  • Cc timograham@… added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted
  • Type changed from Uncategorized to Bug

We won't update the docs for 1.3 as that version is no longer supported. Please patch against master and I will see how clean the backports are to older versions.

comment:2 Changed 2 years ago by jmichalicek

Thanks, I just made a pull request for https://github.com/jmichalicek/django/tree/fix_20855 which updates docs/topics/auth/default.txt to add in documentation of those features. I also touched up the django.contrib.auth.login() docs by adding in the optional arguments section like the rest of the views on the page have.

comment:3 Changed 2 years ago by jmichalicek

  • Has patch set
  • Owner changed from nobody to jmichalicek
  • Status changed from new to assigned

comment:4 Changed 2 years ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 61ecb5f48a4732f1471f858c64904ec1c4763925:

Fixed #20855 -- Added documentation of current_app and extra_context params to django.contrib.auth views

refs #5298 and refs #8342

comment:6 Changed 2 years ago by Tim Graham <timograham@…>

In 77293f9354774e2631087935f1550c674093c433:

[1.6.x] Fixed #20855 -- Added documentation of current_app and extra_context params to django.contrib.auth views

refs #5298 and refs #8342

Backport of 61ecb5f48a from master

comment:5 Changed 2 years ago by Tim Graham <timograham@…>

In 145e0a14f0c098d7bbf2bfb593f7b6cfe1b02d72:

[1.5.x] Fixed #20855 -- Added documentation of current_app and extra_context params to django.contrib.auth views

refs #5298 and refs #8342

Backport of 61ecb5f48a from master.

Note: See TracTickets for help on using tickets.
Back to Top