Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#20781 closed Bug (fixed)

Regression in form field _has_changed for fields with show_hidden_initial=True

Reported by: Tim Graham Owned by: nobody
Component: Forms Version: 1.6-beta-1
Severity: Release blocker Keywords:
Cc: Claude Paroz Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Following [892bc91cb0] (affects 1.6.X), the date_joined and last_login fields always appear as "Changed" when editing a user in the admin. It looks like it affects fields with callable defaults. In this case, django.forms.fields.Field._has_changed returns False because initial_value is a string and data_value is a datetime.

I discovered this working on #19019, the ​PR contains some TODOs which could be used as a regression test once this is fixed.

Change History (5)

comment:1 by Claude Paroz, 11 years ago

Cc: Claude Paroz added
Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted

comment:2 by Claude Paroz, 11 years ago

Has patch: set

Tim, can you check if this commit fixes your issue:
​https://github.com/claudep/django/commit/25a38cf3f66daed8ab17aa33b2955ee4ccde0407

comment:3 by Tim Graham, 11 years ago

Triage Stage: Accepted → Ready for checkin

It does, thanks for looking into it!

comment:4 by Claude Paroz <claude@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In 02b0106d43f6997f02cc6785359f8f7519215d3d:

Fixed #20781 -- Fixed _has_changed regression with MultiValueField

Thanks Tim Graham for the report.

comment:5 by Claude Paroz <claude@…>, 11 years ago

In 816bf0c6a7a13efb7ae17c9773f984f2dd16fc72:

[1.6.x] Fixed #20781 -- Fixed _has_changed regression with MultiValueField

Thanks Tim Graham for the report.
Backport of 02b0106d from master.

Note: See TracTickets for help on using tickets.
Back to Top