#19019 closed New feature (fixed)
UserAdmin.user_change_password does not log the change
Reported by: | Vlada Macek | Owned by: | nobody |
---|---|---|---|
Component: | contrib.auth | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | galuszkak@…, timograham@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
I found myself missing the LogEntry added when the user password is changed through the admin. Calling self.log_change with save() would be nice.
Change History (13)
comment:1 by , 12 years ago
Has patch: | set |
---|
comment:5 by , 11 years ago
Cc: | added |
---|
wckd: Tests doesn't work actualy with master.
AssertionError: u'Changed last_login and date_joined.' != 'No fields changed.' AssertionError: u'Changed email, last_login and date_joined.' != 'Changed email.'
comment:6 by , 11 years ago
comment:8 by , 11 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
Ok. After merging #18709 tests are passing.
comment:9 by , 11 years ago
Cc: | added |
---|---|
Patch needs improvement: | set |
Triage Stage: | Ready for checkin → Accepted |
Left some comments on the pull request, needs minor tweaks.
comment:10 by , 11 years ago
Patch needs improvement: | unset |
---|
Here's an updated pull request. As the test demonstrates and as I noticed testing another project, the dated_joined
and last_login
fields always appear in the list of fields that have changed -- it looks like a separate bug.
comment:12 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Patch on github https://github.com/django/django/pull/464