[patch] HttpResponseRedirect should percent-encode non-ASCII characters in Location header

[Andrey <aela@…>]

​RFC 3986 does not allow non-ASCII characters in URIs. Instead they should be converted to bytes according to UTF-8 and then replaced by %XX sequences, where XX is the hexadecimal value of the byte.

[Andrey <aela@…>]

A simple code for percent-encoding of strings

[Adrian Holovaty]

Can we not use one of the utility functions in urllib or urllib2 for this?

[Andrey]

Yes, seems like urllib.quote is almost what we need. We just have to tell it to leave HTTP reserved characters unquoted, like this: urllib.quote(url, safe="!*'();:@&=+$,/?%#[]")

[Andrey]

Use urllib.quote for percent-encoding URLs in HttpResponseRedirect and HttpResponsePermanentRedirect

[Alexander Petrov]

I am currentry writing a Django-based mini-wiki, and of course I'd want to have non-latin character in article titles (I am a native Russian speaker). Unfortunately, Django still chokes on cyrilic characters in URLs. For example, if an URL with cyrillic character and wihout trailing slash is entered in browser (say, ​http://some.host/wiki/Проверка), it does not get redirected correctly (you get some cruft like ​http://some.host/wiki/Проверка/ instead of ​http://some.host/wiki/Проверка/).

This patch above fixes this issue, so it would be really nice to have it merged. :)

[Adrian Holovaty]

(In [3166]) Fixed #2078 -- Improved HttpResponseRedirect and HttpResponsePermanentRedirect to percent-encode non-ASCII characters in the Location header. Thanks, Andrey

[shivaraj]

Recently I came across ​http://www.djangosnippets.org/snippets/1048/ and I found
params = {'v':'1.0', 'q': text.encode('utf-8')}
to be the encoded format for urlopening translation apis with non-ASCII characters,
when I didn't succeed in sending a escaped version used here to call translate api from django.

[dc]

The original bug was fixed three years ago. Please ask on ​django-users and open a new ticket with detailed information about your problem if you are sure it is a django bug.