Opened 11 years ago
Closed 8 years ago
#20705 closed New feature (fixed)
Allow customizing the email field name for PasswordResetForm
Reported by: | CHI Cheng | Owned by: | mlevental |
---|---|---|---|
Component: | contrib.auth | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | CHI Cheng, jorgecarleitao, Aleksej Manaev, m.levental@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Like USERNAME_FIELD, add a similar parameter so PasswordResetForm, and other customized user model functions, do not rely on fixed name email field to send emails.
Attachments (1)
Change History (13)
comment:1 by , 11 years ago
Cc: | added |
---|
comment:2 by , 11 years ago
Summary: | Set email field for PasswordResetForm → Allow customizing the email field name for PasswordResetForm |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:3 by , 11 years ago
I've been reading this doc for context + background: https://docs.djangoproject.com/en/1.5/topics/auth/default/#django.contrib.auth.forms.PasswordResetForm
It seems that I'll need to edit the PasswordResetForm class method located in contrib.auth.forms
. In particular, L27 might needed to be changed: "email = forms.EmailField(label=_("Email"), max_length=254)"
Is there an existing similar example that I can follow? I've done a global search on USERNAME_FIELD, which returned a lot of results; I'm not sure which are the relevant files to look at.
comment:4 by , 11 years ago
This isn't about renaming the form field, but rather not assuming the "email" field on the UserModel
is called "email". We could accomplish this on PasswordResetForm
by passing in a parameter to the save
method with the name of the field, but it would be better to get an idea of the "other customized user model functions" the OP had in mind to better determine the feasibility and design of this.
comment:6 by , 9 years ago
No, I think it's still an issue. I'll attach a patch with a sketch of the code changes.
by , 9 years ago
Attachment: | 20705-initial.diff added |
---|
comment:7 by , 8 years ago
Cc: | added |
---|
comment:8 by , 8 years ago
Cc: | added |
---|
comment:9 by , 8 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:10 by , 8 years ago
Has patch: | set |
---|---|
Patch needs improvement: | set |
I left some ideas for improvement on the PR.
comment:11 by , 8 years ago
Patch needs improvement: | unset |
---|
Seems like a reasonable request.