Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#20654 closed Bug (fixed)

Type mismatch in the docs for m2m_changed's pk_set argument

Reported by: izquierdo Owned by: nobody
Component: Documentation Version: 1.5
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The docs state that m2m_changed's pk_set argument is a list of primary key values: https://docs.djangoproject.com/en/dev/ref/signals/

But it's actually a set. See: https://github.com/django/django/blob/master/django/db/models/fields/related.py

Pull request: https://github.com/django/django/pull/1302

Change History (3)

comment:1 Changed 2 years ago by claudep

  • Easy pickings set
  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin
  • Type changed from Uncategorized to Bug

comment:2 Changed 2 years ago by Baptiste Mispelon <bmispelon@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 9a2b07f1b45741da39a7606474aec3548780032b:

Fixed #20654 -- Fixed type of m2m_changed's pk_set arg in docs

comment:3 Changed 2 years ago by Tim Graham <timograham@…>

In 030ef4d1afe8c49da24ae7e6a1b8205041db8c61:

[1.5.x] Fixed #20654 -- Fixed type of m2m_changed's pk_set arg in docs

Backport of 9a2b07f1b4 from master

Note: See TracTickets for help on using tickets.
Back to Top