Code

#20515 closed Cleanup/optimization (fixed)

Clarification in release notes of location of translator comments

Reported by: wim@… Owned by: nobody
Component: Documentation Version: 1.6-alpha-1
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: no UI/UX: no

Description

Hi all,

I find the following sentences extremely difficult to comprehend. Maybe we can reword them in order to clarify a bit.

Original text:

Validation of the placement of Comments for translators in templates specified using {# / #} is now stricter. All translator comments not located at the end of their respective lines in a template are ignored and a warning is generated by makemessages when it finds them. E.g.:

{# Translators: This is ignored #}{% trans "Translate me" %}
{{ title }}{# Translators: Extracted and associated with 'Welcome' below #}
<h1>{% trans "Welcome" %}</h1>

Proposal:
Translator comments in templates need to be at the end of a line. If not, a warning is generated by makemessages when it finds them in the wrong place. For example, this raises an error.

(Actually, I am not sure about whether I interpreted the text correctly so my text may be plain wrong).

Attachments (0)

Change History (1)

comment:1 Changed 14 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In f513764e72faf6bd4be1f063d2842cd4e5d76f7d:

Fixed #20515 - Clarified note regarding translator comments.

Thanks wim@ for the suggestion.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.