Opened 11 years ago

Closed 11 years ago

#20450 closed Cleanup/optimization (wontfix)

Consistent usage of `BLANK_CHOICE_DASH`

Reported by: pyriku Owned by: pyriku
Component: Forms Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

For fields with choices, we're using BLANK_CHOICE_DASH (​https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L36), but we're not in other similar places like for ModelChoiceFeld (​https://github.com/django/django/blob/master/django/forms/models.py#L1005).

There are several tests already for this subject like ​https://github.com/django/django/blob/master/tests/model_forms/tests.py#L1110, so I doubt that will need more tests, just don't break existing ones.

Change History (2)

comment:2 by pyriku, 11 years ago

Resolution: → wontfix
Status: new → closed
Note: See TracTickets for help on using tickets.
Back to Top