Opened 11 years ago
Closed 10 years ago
#20449 closed Bug (fixed)
New test runner test fails if run from a different directory
Reported by: | Chris Wilson | Owned by: | tadeck |
---|---|---|---|
Component: | Testing framework | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | marc.tamlyn@…, tadeck | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
====================================================================== ERROR: test_file_path (test_runner.test_discover_runner.DiscoverRunnerTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/travis/build/aptivate/django/tests/test_runner/test_discover_runner.py", line 65, in test_file_path ["test_discovery_sample/"], File "/home/travis/build/aptivate/django/django/test/runner.py", line 63, in build_suite tests = self.test_loader.loadTestsFromName(label) File "/usr/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName module = __import__('.'.join(parts_copy)) ImportError: Import by filename is not supported.
<https://next.travis-ci.org/aptivate/django/jobs/7275360>
It seems to be checking if a file exists, using a relative path, in django/test/runner.py:65:
if not os.path.exists(label_as_path): tests = self.test_loader.loadTestsFromName(label)
And that will behave differently depending if you run your tests from inside the tests directory like this:
./runtests.py -v2 --settings=test_postgres_nogis test_runner
Or from the parent directory, as Travis currently does, like this:
python -Wall tests/runtests.py --selenium --verbosity 2 \ --settings=django_settings
I can work around it in Travis by changing working directory before running the tests, but is it worth fixing this in the test runner, perhaps using an absolute path based on __file__
?
Carl Meyer wrote:
I don't think this should be fixed in the test runner itself; in general, file-path test labels _should_ be interpreted as relative to wherever you are running the tests from.
But it should be fixed in the test_runner.test_discover_runner.DiscoverRunnerTest.test_file_path test - that test apparently needs to isolate itself better by setting the CWD for the duration of the test, or something similar. Mind filing a bug? I should be able to take a look soon.
So here it is :)
Attachments (2)
Change History (11)
comment:1 by , 11 years ago
Version: | 1.4 → master |
---|
comment:2 by , 11 years ago
Cc: | added |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:3 by , 11 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Type: | Uncategorized → Bug |
by , 11 years ago
by , 11 years ago
Attachment: | 1153.patch added |
---|
PATCH for ticket #20449, from pull request no. 1153 (https://github.com/django/django/pull/1153)
comment:4 by , 11 years ago
Cc: | added |
---|---|
Has patch: | set |
Resolution: | → fixed |
Status: | assigned → closed |
Pull request waiting for review: https://github.com/django/django/pull/1153
It uses context manager to temporarily change current working directory to one level up, then switches it back to what it was.
follow-up: 6 comment:5 by , 11 years ago
Resolution: | fixed |
---|---|
Status: | closed → new |
Tickets are closed when the code is merged, not when the pull request is created.
comment:6 by , 11 years ago
Replying to mjtamlyn:
Tickets are closed when the code is merged, not when the pull request is created.
I am sorry, that was not intentional. Missed note on https://docs.djangoproject.com/en/dev/internals/contributing/triaging-tickets/#closing-tickets (and marking ticket as fixed resulted in closing it).
comment:7 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:8 by , 10 years ago
Resolution: | fixed |
---|---|
Status: | closed → new |
Fixed in: https://github.com/django/django/pull/2657
This also happens to the (newer) test_testcase_ordering()
with the current master:
tests/runtests.py test_runner Testing against Django installed in '/home/dev/django/django/django' Creating test database for alias 'default'... Creating test database for alias 'other'... .............E.ss................. ====================================================================== ERROR: test_testcase_ordering (test_runner.test_discover_runner.DiscoverRunnerTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/dev/django/django/tests/test_runner/test_discover_runner.py", line 107, in test_testcase_ordering suite = DiscoverRunner().build_suite(["test_discovery_sample/"]) File "/home/dev/django/django/django/test/runner.py", line 66, in build_suite tests = self.test_loader.loadTestsFromName(label) File "/usr/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName module = __import__('.'.join(parts_copy)) ImportError: Import by filename is not supported. ---------------------------------------------------------------------- Ran 34 tests in 1.811s FAILED (errors=1, skipped=2) Destroying test database for alias 'default'... Destroying test database for alias 'other'...
which can be fixed by applying the already existing with change_cwd(".."):
pattern - maybe this might be moved to setUp()
?
comment:9 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
DIFF for ticket #20449, from pull request no. 1153 (https://github.com/django/django/pull/1153)