Opened 5 years ago

Closed 4 years ago

#19849 closed Cleanup/optimization (fixed)

ORM cleanup

Reported by: Anssi Kääriäinen Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Three items:

I plan to commit these shortly.

Change History (6)

comment:1 Changed 5 years ago by Anssi Kääriäinen

Triage Stage: UnreviewedAccepted

comment:2 Changed 4 years ago by Anssi Kääriäinen <akaariai@…>

In 3fef304ff237fe692459c1f5b840acf7886c50bb:

Refactored negated IS NULL handling

This one cleaned up add_filter() negated filter generation. As a side
effect split_exclude() was cleaned up, too.

Refs #19849

comment:3 Changed 4 years ago by Anssi Kääriäinen <akaariai@…>

In edf93127bf2f9dc35b45cdea5d39a1b417ab1638:

Removed join() promote kwarg

The join promote=True was over-aggressive in select_related handling.
After that was removed, the only other user was query.combine(). That
use case is very easy to handle locally, so there is no more need for
the join(promote=True) flag.

Refs #19849.

comment:4 Changed 4 years ago by Anssi Kääriäinen <akaariai@…>

In 10f9ba046f6122414fe5501934b6e080c3554a85:

Cleaned up join promotion in query.combine() with OR

Refs #19849

comment:5 Changed 4 years ago by Anssi Kääriäinen <akaariai@…>

In e8fc3f3783744e4fcd3ff0ac43e3ce2572292f3a:

Added a test for negated Q object querying

The added test is from the patch in ticket #19672 (written by Ian
Kelly). Fixed #19672, refs #19849.

comment:6 Changed 4 years ago by Anssi Kääriäinen

Resolution: fixed
Status: newclosed

I forgot to close this after the commits...

Note: See TracTickets for help on using tickets.
Back to Top