Opened 12 years ago
Closed 12 years ago
#19849 closed Cleanup/optimization (fixed)
ORM cleanup
Reported by: | Anssi Kääriäinen | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Three items:
- Cleanup IS NOT NULL condition generation for negated lookups in add_filter() (also fixes one bug, and simplifies split_exclude()). Handled in commit: https://github.com/akaariai/django/commit/4d8ed818beb59b1e6d04eead6c9dad0bf2bdafb7
- Removal of Query.join()'s promote kwarg. This also improves handling of promotion in select_related(). Before select_related() always promoted any used join if nullable, now only if the join is newly created. In case there is already existing inner join we know any null value will remove results in any case, so the louter join is wrong here. Commit: https://github.com/akaariai/django/commit/f7f7044dedabdd04b6806409239e040c25d2bb83
- Cleaned up join promotion in combine(), commit: https://github.com/akaariai/django/commit/bfc88e7e3dded3d4259d70f31d65d36b0e197144
I plan to commit these shortly.
Change History (6)
comment:1 by , 12 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 12 years ago
comment:6 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
I forgot to close this after the commits...
Note:
See TracTickets
for help on using tickets.
In 3fef304ff237fe692459c1f5b840acf7886c50bb: