Opened 11 years ago

Closed 11 years ago

#19713 closed Cleanup/optimization (fixed)

Rename inspectdb tests model's field for clarity

Reported by: Simon Charette Owned by: nobody
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The recently added inspect db ​test refers to model field by numerical index.

The attached patch name those fields based on their type for clarity. This also fixes the regression on MySQL concerning blank and null ordering in NullBooleanField.

Attachments (1)

0001-Renamed-inspectdb-field-names-for-clarity.patch​ (8.5 KB ) - added by Simon Charette 11 years ago.

Download all attachments as: .zip

Change History (3)

by Simon Charette, 11 years ago

Attachment: 0001-Renamed-inspectdb-field-names-for-clarity.patch​ added

comment:1 by Simon Charette, 11 years ago

inspectdb tests pass on Python 2.7.3 and 3.2.3, SQLite, Postgresql and PostGIS.

comment:2 by Claude Paroz, 11 years ago

Resolution: → fixed
Status: new → closed
Triage Stage: Unreviewed → Accepted

Fixed in [339944491ce06be8e1a8e7f2027261c90d1f166b]

Note: See TracTickets for help on using tickets.
Back to Top