Opened 3 years ago

Closed 3 years ago

#19713 closed Cleanup/optimization (fixed)

Rename inspectdb tests model's field for clarity

Reported by: charettes Owned by: nobody
Component: Testing framework Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The recently added inspect db test refers to model field by numerical index.

The attached patch name those fields based on their type for clarity. This also fixes the regression on MySQL concerning blank and null ordering in NullBooleanField.

Attachments (1)

0001-Renamed-inspectdb-field-names-for-clarity.patch (8.5 KB) - added by charettes 3 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 3 years ago by charettes

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

inspectdb tests pass on Python 2.7.3 and 3.2.3, SQLite, Postgresql and PostGIS.

comment:2 Changed 3 years ago by claudep

  • Resolution set to fixed
  • Status changed from new to closed
  • Triage Stage changed from Unreviewed to Accepted
Note: See TracTickets for help on using tickets.
Back to Top