Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#19639 closed Uncategorized (fixed)

Choices in model fields best practices consistency

Reported by: Simon Charette Owned by: nobody
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

As reported here, models coding style concerning choices is not consistent with the best practices introduced by #18062.

Attachments (1)

coding-style.patch (1.1 KB) - added by anonymous 4 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 4 years ago by Tim Graham

Easy pickings: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Changed 4 years ago by anonymous

Attachment: coding-style.patch added

comment:2 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In eaa716a4130bb019204669d32389db8b399c0f71:

Fixed #19639 - Updated contributing to reflect model choices best practices.

Thanks charettes.

comment:3 Changed 4 years ago by Tim Graham <timograham@…>

In d571894fc09b34b8b43cb8f1790c743a47679851:

[1.5.x] Fixed #19639 - Updated contributing to reflect model choices best practices.

Thanks charettes.

Backport of eaa716a413 from master

comment:4 Changed 4 years ago by Tim Graham <timograham@…>

In d571894fc09b34b8b43cb8f1790c743a47679851:

[1.5.x] Fixed #19639 - Updated contributing to reflect model choices best practices.

Thanks charettes.

Backport of eaa716a413 from master

Note: See TracTickets for help on using tickets.
Back to Top