Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#19638 closed Cleanup/optimization (fixed)

Oracle: add "supports_transactions=True" to DatabaseFeatures

Reported by: shai Owned by: nobody
Component: Database layer (models, ORM) Version: 1.4
Severity: Normal Keywords: oracle
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Oracle supports transactions. Writing this into the backend, instead of relying on the default test, saves a little work (per thread) and removes a requirement for table-creation permissions.

(This used to cause testing issues with Django 1.3, nowadays it's just a minor thing. Supported by Ian Kelly, https://groups.google.com/d/msg/django-developers/UASD8v7qQkg/k7pxdGfgEioJ).

Patch: in django/db/backends/oracle/base.py, line 87, add this new line:

    supports_transactions=True

Thanks, Shai.

Change History (3)

comment:1 Changed 3 years ago by akaariai

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Seems valid.

comment:2 Changed 2 years ago by Anssi Kääriäinen <akaariai@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 0478780b8efdfcbc0d2c17f1459cac45701e1d86:

Fixed #19638 -- Skipped tx support testing for some DBs

PostgreSQL and Oracle always support transactions, so the create table
and rollback test is non-necessary on those DBs.

Thanks to shai for report.

comment:3 Changed 2 years ago by Anssi Kääriäinen <akaariai@…>

In d8e68f421e676de16953090c187e165a6c1ed900:

[1.5.x] Fixed #19638 -- Skipped tx support testing for some DBs

PostgreSQL and Oracle always support transactions, so the create table
and rollback test is non-necessary on those DBs.

Thanks to shai for report.

Backpatch of 0478780b8efdfcbc0d2c17f1459cac45701e1d86

Note: See TracTickets for help on using tickets.
Back to Top