Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19389 closed Bug (fixed)

Wrong location of admin tests in documentation

Reported by: KJ Owned by: nobody
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As tests for admin live in tests/regressiontests/admin_*, the following info in internals/contributing/writing-code/unit-tests:

The tests cover:

  • Models and the database API (tests/modeltests),
  • Everything else in core Django code (tests/regressiontests),
  • Contrib apps (django/contrib/<app>/tests).

is misleading. There is a small file django/contrib/admin/tests.py, but inside of it no comment is made redirecting user to tests/regressiontests.

Change History (4)

comment:1 Changed 3 years ago by timo

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Not a comprehensive audit, but I also see tests for contrib.comments and contrib.syndication in tests/regressiontests. Do we want to fix this by modifying the documentation or by moving around the tests?

comment:2 Changed 3 years ago by aaugustin

  • Triage Stage changed from Unreviewed to Accepted

Let's start by fixing the documentation.

comment:3 Changed 3 years ago by Aymeric Augustin <aymeric.augustin@…>

  • Resolution set to fixed
  • Status changed from new to closed

In d5ed81c7951578c8cf0eb6fefd09db632455edd0:

Fixed #19389 -- Docs on the location of contrib apps tests.

comment:4 Changed 3 years ago by Aymeric Augustin <aymeric.augustin@…>

In c81e8e7068bdaa000ad6fbed8d452ac074ba19a9:

[1.5.x] Fixed #19389 -- Docs on the location of contrib apps tests.

Backport of d5ed81c.

Note: See TracTickets for help on using tickets.
Back to Top