Closing SMTP backend raises AttributeError when already closed
|Reported by:||sebastian_noack||Owned by:||nobody|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||yes||Patch needs improvement:||no|
>>> from django.core.mail import get_connection >>> smtp = get_connection('django.core.mail.backends.smtp.EmailBackend') >>> smtp.close() Traceback (most recent call last): File "<console>", line 1, in <module> File "/home/sebastian/p24/src/placement24/placement24/django/core/mail/backends/smtp.py", line 66, in close self.connection.quit() AttributeError: 'NoneType' object has no attribute 'quit'
The SMTP backend is the only mail backend that can't be closed without opening it. In fact the filebased backend contains code to explicitly handle that case. So the smtp backend should handle it as well.
If that is not reason enough, note that it is not always possible to know whether the connection is open and must be closed or not. For example, when open() was called and an SMTP connection was established, but the login failed, close() must be called even though open() raised an exception. However when the exception was raised while establishing the connection, close() would raise the AttributeError, shown above.
Therefore the close() method must just return in case the connection isn't open.
Change History (5)
Changed 3 years ago by sebastian_noack
comment:1 Changed 3 years ago by atykhonov
- Easy pickings set
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Triage Stage changed from Unreviewed to Ready for checkin
comment:2 Changed 3 years ago by claudep
- Needs tests set
- Triage Stage changed from Ready for checkin to Accepted
- Type changed from Uncategorized to Bug