Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19291 closed Bug (fixed)

Sort out deprecation of ADMIN_MEDIA_PREFIX

Reported by: ptone Owned by: aaugustin
Component: Documentation Version: master
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The deprecation of this setting went in for 1.4 straight as a DeprecationWarning, not PendingDeprecation.

https://github.com/django/django/commit/38a2444277a84eb6b74425f0e324d1dceb7d2ef1

However an accelerated timeline wasn't mentioned in the release notes, and it was not added to the deprecation timeline.

Should we pull it in 1.5 - or give it till 1.6? Either way - it needs to be added to the deprecation timeline.

Given that it was not in the timeline - I feel we should probably leave it in till 1.6?

Attachments (1)

19291.patch (4.0 KB) - added by aaugustin 2 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 2 years ago by jezdez

The admin is a contrib app which doesn't completely adhere to the deprecation policy.

Also, the ADMIN_MEDIA_PREFIX setting was a crux and had a better alternative with STATIC_URL + /admin/ that was introduced before. The "accelerated deprecation" thing you mention is a new policy that wasn't around when I removed the setting, so it wasn't clearly mentioned as that in the release notes. Feel free to add it if you are so inclined.

But for the love of god, remove it in 1.5, it was a stupid setting.

Last edited 2 years ago by jezdez (previous) (diff)

Changed 2 years ago by aaugustin

comment:2 Changed 2 years ago by aaugustin

  • Has patch set
  • Owner changed from nobody to aaugustin
  • Triage Stage changed from Design decision needed to Accepted

comment:3 Changed 2 years ago by Aymeric Augustin <aymeric.augustin@…>

  • Resolution set to fixed
  • Status changed from new to closed

In a586f2a7e56b854bb13403524259289974c7232c:

[1.5.x] Fixed #19291 -- Completed deprecation of ADMIN_MEDIA_PREFIX.

Backport of 9b755a2 from master.

comment:4 Changed 2 years ago by Aymeric Augustin <aymeric.augustin@…>

In 9b755a298a55849bf8e831a46639999609aedfff:

Fixed #19291 -- Completed deprecation of ADMIN_MEDIA_PREFIX.

Note: See TracTickets for help on using tickets.
Back to Top