Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#19239 closed Cleanup/optimization (fixed)

Provide examples in the ref docs for Generic date views

Reported by: Daniel Greenfeld Owned by: Daniel Greenfeld
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: citadelgrad, timograham@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

The reference docs need codes examples as done in https://docs.djangoproject.com/en/dev/ref/class-based-views/base/.

This makes the reference documentation much easier to use, and makes them a place for canonical examples of how things should or could be done.

Change History (8)

comment:1 by Daniel Greenfeld, 11 years ago

I'm working this ticket with @scottnixon at https://github.com/citadelgrad/django/tree/ticket_19239. Should be ready to push for review in 1-2 days.

comment:2 by Preston Holmes, 11 years ago

Component: UncategorizedDocumentation
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization
Version: 1.4master

comment:3 by Daniel Greenfeld, 11 years ago

Submitted pull request for this ticket at https://github.com/django/django/pull/517.

Work performed with @citadelgrad / Scott Nixon of https://github.com/citadelgrad.

comment:4 by Tim Graham, 11 years ago

Has patch: set

comment:5 by Tim Graham, 11 years ago

Cc: timograham@… added
Patch needs improvement: set

Waiting on Danny to update the original pull request based on feedback.

comment:6 by Daniel Greenfeld, 11 years ago

Just updated pull request https://github.com/django/django/pull/517, which meant fixing a bad merge and then incorporating @timo's requests.

The work is in https://github.com/citadelgrad/django/commit/45350359921a325036390e46afc10f53488e360c.

Thanks @timo and @citadelgrad!

comment:7 by Tim Graham <timograham@…>, 11 years ago

Resolution: fixed
Status: newclosed

In 38055222bd4f56bac6ae0f7a53c07bf924967daf:

Fixed #19239 - Added examples for generic date views

Thank-you Daniel Greenfeld and Scott Nixon.

comment:8 by Tim Graham <timograham@…>, 11 years ago

In ecf292aa2c89935bbc243d29ead3e01f1380e246:

[1.5.X] Fixed #19239 - Added examples for generic date views

Thank-you Daniel Greenfeld and Scott Nixon.

Backport of 38055222bd from master

Note: See TracTickets for help on using tickets.
Back to Top