Admin readonly fields ignore newlines

[shadow]

A TextField that is marked as readonly in the Admin will be displayed in a simple <p>, effectively removing any newlines that were entered. Since in HTML, <textarea> displays newlines as you enter them, it would be more appropriate if <pre> were used to display the data when it is readonly.

See: contrib/admin/templates/admin/includes/fieldset.html:17

thanks

[shadow]

A nicer solution (rather than <pre>) might be:

<p>{{ field.contents|linebreaksbr }}</p>

As this avoids the other styling that goes along with <pre>

[Claude Paroz]

I think you could tweak the existing test_readonly_get in admin_views tests to include a new line in some value.

[Claude Paroz]

You are near, but you have tested a non-readonly field, otherwise the test would have failed (as you should get <br> instead of newlines).

[thiderman]

Patch with tests for br tags

[thiderman]

I fixed the last patch so that it actually executes and added an assertion that the conversion into <br /> tags was actually made.

[Claude Paroz <claude@…>]

In ec9d6b1122dd09168d8b2dbcabc745f22f0ef766:

Fixed #19226 -- Applied linebreaksbr to read-only fields in admin

Thanks shadow for the report, and Melevir and thiderman for the
patch.

[Claude Paroz <claude@…>]

In 1b6e751430b6c151079f616ec5d4f8f3446ea24e:

[1.5.x] Fixed #19226 -- Applied linebreaksbr to read-only fields in admin

Thanks shadow for the report, and Melevir and thiderman for the
patch.
Backport of ec9d6b112 from master.

[anonymous]

Yep guys,
I've found that this is not fixed for inlines. I've opened this ticket: #19429

[atodorov@…]

Hi guys,
this fix is breaking up display for me. I'm using computed read-only fields which display rich HTML into the model change form as a way to augment the administration experience which works really well for me.

Adding multiple line break tags breaks my display (this only happens because the templates used to render the fields have new lines in them). Now I have to go all-over my code and strip new lines before returning the field value.

It would be nice if the linebreaks filter skipped \n, <br/> replacement on safe strings.

[Claude Paroz]

Hi, could you please open a new ticket (referencing this one) with your use case instead of reopening a rather old ticket? And it would probably help understanding of your issue if you can provide some code example, maybe even screenshots.

[anonymous]

See:
https://code.djangoproject.com/ticket/22241