Opened 3 years ago

Closed 3 years ago

#19179 closed Bug (fixed)

NamedUrlSessionWizard and NamedUrlCookieWizard undocumented

Reported by: tom@… Owned by: nobody
Component: Documentation Version: 1.4
Severity: Normal Keywords: SessionWizardView, NamedUrlWizardView
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

When creating a formtools.wizard.views.NamedUrlWizardView you must subclass both SessionWizardView and NamedUrlWizardView. This is ran me for a bit of a loop today, and their is no mention of this in the documentation.

Example of a view:

class SubClassOfFormWizard(SessionWizardView, NamedUrlWizardView):
    def done(self, form_list, **kwargs):
    return render_to_response('finished.html', {
        'form_data': [form.cleaned_data for form in form_list], 
    })

Change History (3)

comment:1 Changed 3 years ago by tom@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

After looking at the code it's now clear that NamedUrlSessionWizard or NamedUrlCookieWizard should be used in place of NamedUrlWizard instead of inheriting from two classes.

comment:2 Changed 3 years ago by timo

  • Easy pickings set
  • Summary changed from No mention of Multiiple Inheritance required for NamedUrlWizardView to NamedUrlSessionWizard and NamedUrlCookieWizard undocumented
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 3 years ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In acab68d8a76c8021a9c7c467e83f5843fe5b2f6c:

[1.5.X] Fixed #19179 - Added mention of NamedUrlSessionWizard and NamedUrlCookieWizard; thanks Tom for the report.

Backport of ede8a0be05 from master

Note: See TracTickets for help on using tickets.
Back to Top