Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#19072 closed Bug (fixed)

GeoDjango/GeoIP docs have outdated info

Reported by: Flavio Curella Owned by: nobody
Component: GIS Version: 1.4
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: yes UI/UX: no

Description

The doc about GeoIP states:

[...] These datasets may be
downloaded from MaxMind. Grab the GeoIP.dat.gz and GeoLiteCity.dat.gz
and unzip them in a directory [...]

On the GeoMind server there isn't any file called GeoIP.dat.gz. The file is now called GeoIPv6.dat.gz

Attachments (1)

geoip_doc.diff​ (1.1 KB ) - added by Flavio Curella 13 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by Flavio Curella, 13 years ago

Has patch: set

comment:2 by Claude Paroz, 13 years ago

Component: Documentation → GIS
Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

I think that Django does not support IPv6 data yet (see #18349). The IPv4 file is now located in the GeoLiteCountry directory.

by Flavio Curella, 13 years ago

Attachment: geoip_doc.diff​ added

comment:3 by Flavio Curella, 13 years ago

Thanks claudep. Path updated.

comment:4 by Claude Paroz, 13 years ago

In your formulation, I'm not sure it's clear enough that one file is in GeoLiteCountry dir and not the other.
What about simply writing the path like that: GeoLiteCountry/GeoIP.dat.gz ? No need for another patch, I'll fix it myself if you agree.

comment:5 by Flavio Curella, 13 years ago

I agree with you, let's go with your version.

Thanks,
Flavio.

comment:6 by Claude Paroz <claude@…>, 13 years ago

Resolution: → fixed
Status: new → closed

In ab8c9703683856eef0346b661e36d6f05db67435:

Fixed #19072 -- Corrected an external file path in GeoIP docs

Thanks Flavio Curella for the report and the initial patch.

comment:7 by Claude Paroz <claude@…>, 13 years ago

In 0636c9583fda5a81a18b47876bcddac62bd2e547:

Fixed #19072 -- Corrected an external file path in GeoIP docs

Thanks Flavio Curella for the report and the initial patch.

Note: See TracTickets for help on using tickets.
Back to Top