Opened 12 years ago
Closed 9 years ago
#18349 closed New feature (wontfix)
Add ipv6 support to django.contrib.gis.geoip
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | GIS | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
libgeoip has support for ipv6 lookups (http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/)
attached patch exposes that functionality and uses it for ipv6 addresses.
Attachments (4)
Change History (11)
by , 12 years ago
Attachment: | django_ipv6_geoip.patch added |
---|
comment:1 by , 12 years ago
Patch needs improvement: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 12 years ago
Patch needs improvement: | unset |
---|
by , 12 years ago
Attachment: | django_ipv6_geoip.4.patch added |
---|
patch updated to 9d2e1f065ede189f65e79eb3cb33a33b460a4351
comment:3 by , 11 years ago
Updated patch to 1.6+ removed one previous unused test also. Tested and works under 2.X and 3.X
https://github.com/django/django/pull/1986
comment:4 by , 10 years ago
Patch needs improvement: | set |
---|
I left comments for improvement on PR. Please uncheck "Patch needs improvement" when you update it, thanks.
comment:5 by , 9 years ago
Patch needs improvement: | unset |
---|
Rebased and tried to fulfil the comments: https://github.com/django/django/pull/5046
I didn't put too much effort in new functionalities, as this is wrapping the legacy GeoIP databases and it should anyway be somewhen rewritten to use the geoip2 python library. But this is out-of-scope here and would deserve a new separate ticket.
comment:6 by , 9 years ago
Created #25184 to add support for GeoLite2. Any objection to closing this as "won't fix" and focusing our efforts on that ticket? I'd think once we support the new format, we could deprecate support for the legacy format anyway.
comment:7 by , 9 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Accepting in general, patch needs tests though.