Opened 5 years ago

Closed 17 months ago

#18349 closed New feature (wontfix)

Add ipv6 support to django.contrib.gis.geoip

Reported by: j@… Owned by: nobody
Component: GIS Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

libgeoip has support for ipv6 lookups (http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/)
attached patch exposes that functionality and uses it for ipv6 addresses.

Attachments (4)

django_ipv6_geoip.patch (5.5 KB) - added by j@… 5 years ago.
django_ipv6_geoip.2.patch (3.9 KB) - added by j@… 5 years ago.
new version of patch, adding a test
django_ipv6_geoip.3.patch (6.1 KB) - added by j@… 5 years ago.
version that has tests and works
django_ipv6_geoip.4.patch (6.1 KB) - added by Flavio Curella 4 years ago.
patch updated to 9d2e1f065ede189f65e79eb3cb33a33b460a4351

Download all attachments as: .zip

Change History (11)

Changed 5 years ago by j@…

Attachment: django_ipv6_geoip.patch added

comment:1 Changed 5 years ago by Jannis Leidel

Patch needs improvement: set
Triage Stage: UnreviewedAccepted

Accepting in general, patch needs tests though.

Last edited 5 years ago by Jannis Leidel (previous) (diff)

Changed 5 years ago by j@…

Attachment: django_ipv6_geoip.2.patch added

new version of patch, adding a test

Changed 5 years ago by j@…

Attachment: django_ipv6_geoip.3.patch added

version that has tests and works

comment:2 Changed 4 years ago by Flavio Curella

Patch needs improvement: unset

Changed 4 years ago by Flavio Curella

Attachment: django_ipv6_geoip.4.patch added

comment:3 Changed 3 years ago by Matthieu Rigal

Updated patch to 1.6+ removed one previous unused test also. Tested and works under 2.X and 3.X
https://github.com/django/django/pull/1986

comment:4 Changed 2 years ago by Tim Graham

Patch needs improvement: set

I left comments for improvement on PR. Please uncheck "Patch needs improvement" when you update it, thanks.

comment:5 Changed 17 months ago by Matthieu Rigal

Patch needs improvement: unset

Rebased and tried to fulfil the comments: https://github.com/django/django/pull/5046

I didn't put too much effort in new functionalities, as this is wrapping the legacy GeoIP databases and it should anyway be somewhen rewritten to use the geoip2 python library. But this is out-of-scope here and would deserve a new separate ticket.

comment:6 Changed 17 months ago by Tim Graham

Created #25184 to add support for GeoLite2. Any objection to closing this as "won't fix" and focusing our efforts on that ticket? I'd think once we support the new format, we could deprecate support for the legacy format anyway.

comment:7 Changed 17 months ago by Tim Graham

Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.
Back to Top