Code

Opened 2 years ago

Last modified 2 days ago

#18349 new New feature

Add ipv6 support to django.contrib.gis.geoip

Reported by: j@… Owned by: nobody
Component: GIS Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

libgeoip has support for ipv6 lookups (http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/)
attached patch exposes that functionality and uses it for ipv6 addresses.

Attachments (4)

django_ipv6_geoip.patch (5.5 KB) - added by j@… 2 years ago.
django_ipv6_geoip.2.patch (3.9 KB) - added by j@… 2 years ago.
new version of patch, adding a test
django_ipv6_geoip.3.patch (6.1 KB) - added by j@… 2 years ago.
version that has tests and works
django_ipv6_geoip.4.patch (6.1 KB) - added by fcurella 21 months ago.
patch updated to 9d2e1f065ede189f65e79eb3cb33a33b460a4351

Download all attachments as: .zip

Change History (8)

Changed 2 years ago by j@…

comment:1 Changed 2 years ago by jezdez

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

Accepting in general, patch needs tests though.

Last edited 2 years ago by jezdez (previous) (diff)

Changed 2 years ago by j@…

new version of patch, adding a test

Changed 2 years ago by j@…

version that has tests and works

comment:2 Changed 21 months ago by fcurella

  • Patch needs improvement unset

Changed 21 months ago by fcurella

comment:3 Changed 8 months ago by MRigal

Updated patch to 1.6+ removed one previous unused test also. Tested and works under 2.X and 3.X
https://github.com/django/django/pull/1986

comment:4 Changed 2 days ago by timo

  • Patch needs improvement set

I left comments for improvement on PR. Please uncheck "Patch needs improvement" when you update it, thanks.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as new
The owner will be changed from nobody to anonymous. Next status will be 'assigned'
as The resolution will be set. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.