#19024 closed Cleanup/optimization (fixed)
FormWizard WizardView.get_form_prefix form argument is unused
Reported by: | kenth | Owned by: | steph |
---|---|---|---|
Component: | contrib.formtools | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
The documentation shows WizardView.get_for_prefix(step). Actual definition is
def get_form_prefix(self, step=None, form=None):
In practice, the form argument is passed.
Attachments (1)
Change History (12)
comment:1 by , 12 years ago
Easy pickings: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
by , 12 years ago
Attachment: | 19024.diff added |
---|
comment:2 by , 12 years ago
Component: | Documentation → contrib.formtools |
---|---|
Has patch: | set |
Summary: | FormWizard WizardView.get_form_prefix signature incorrect → FormWizard WizardView.get_form_prefix form argument is unused |
Triage Stage: | Accepted → Ready for checkin |
Type: | Bug → Cleanup/optimization |
comment:3 by , 12 years ago
To be completely sure, you could try to ping Stephan Jaekel, which might be the original author of this code (https://github.com/stephrdev/django-formwizard/commit/1301efd06383df727e455d08eee3ef3dc1f98d27).
comment:4 by , 12 years ago
I think removing the argument isn't a good idea. The get_form_prefix method is public api and some developers may use the form argument to determine the form prefix. Therefore, I updated the docs for the get_form_prefix method. (Please see https://github.com/stephrdev/django/commit/aa5b0a3ae8ff7abef3c64787dc09ff1ce17993c1)
comment:5 by , 12 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:6 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Actually, this argument isn't used so I'd suggest we remove it.