Opened 12 years ago

Closed 12 years ago

#18634 closed Bug (fixed)

Escaping in the startproject command

Reported by: Marc Tamlyn Owned by: nobody
Component: Core (Management commands) Version: dev
Severity: Normal Keywords:
Cc: Florian Apolloner Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The startproject command uses the template language, and seems to be html-escaping various things. For example aviraldg reported on IRC getting a SECRET_KEY with several instances of & in the middle of the string.

In this context it's harmless, but it may break other places where & or < are legitimate characters. We should probably render the whole template with escaping disabled.

Change History (3)

comment:1 by Aymeric Augustin, 12 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Marc Tamlyn, 12 years ago

Has patch: set
Needs tests: set

See Pull Request here: ​https://github.com/django/django/pull/214

comment:3 by Florian Apolloner <florian@…>, 12 years ago

Resolution: → fixed
Status: new → closed

In [a875f612e0ae84c2084d0b6230ffafe32a9777c8]:

Fixed #18634 -- Don't escape variables in the context for startproject/startapp.

The & symbols which can come up in the secret key were
being escaped to &amp;.

Note: See TracTickets for help on using tickets.
Back to Top