Opened 3 years ago

Closed 2 years ago

#18551 closed New feature (fixed)

skipIfDBFeature/skipUnlessDBFeature cannot be used as class decorators

Reported by: claudep Owned by: nobody
Component: Testing framework Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

It would be nice to be able to skip an entire test class with skipIfDBFeature/skipUnlessDBFeature decorators.

Attachments (3)

18551.diff (3.2 KB) - added by claudep 3 years ago.
Allow skipUnlessDBFeature / skipIfDBFeature to decorate a class
18551-2.diff (3.5 KB) - added by claudep 3 years ago.
Really defer checking condition for classes
18551-3.diff (3.3 KB) - added by timo 2 years ago.

Download all attachments as: .zip

Change History (9)

Changed 3 years ago by claudep

Allow skipUnlessDBFeature / skipIfDBFeature to decorate a class

comment:1 Changed 3 years ago by claudep

  • Has patch set

comment:2 Changed 3 years ago by claudep

  • Patch needs improvement set

Obviously the condition is not deferred enough in the "decorator()" definition. Needs more work...

Changed 3 years ago by claudep

Really defer checking condition for classes

comment:3 Changed 3 years ago by claudep

  • Patch needs improvement unset

comment:4 Changed 3 years ago by aaugustin

  • Triage Stage changed from Unreviewed to Accepted

Changed 2 years ago by timo

comment:5 Changed 2 years ago by timo

  • Triage Stage changed from Accepted to Ready for checkin

Updated the patch to apply cleanly and get the tests passing on PY3.

comment:6 Changed 2 years ago by Claude Paroz <claude@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 6d52844b9b3c0bd18eea03ac9dc499782b84c36b:

Fixed #18551 -- Enabled skipIfDBFeature/skipUnlessDBFeature to decorate a class

Thanks Tim Graham for the review and improved patch.

Note: See TracTickets for help on using tickets.
Back to Top