Opened 14 years ago

Closed 13 years ago

#18551 closed New feature (fixed)

skipIfDBFeature/skipUnlessDBFeature cannot be used as class decorators

Reported by: Claude Paroz Owned by: nobody
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

It would be nice to be able to skip an entire test class with skipIfDBFeature/skipUnlessDBFeature decorators.

Attachments (3)

18551.diff​ (3.2 KB ) - added by Claude Paroz 14 years ago.
Allow skipUnlessDBFeature / skipIfDBFeature to decorate a class
18551-2.diff​ (3.5 KB ) - added by Claude Paroz 14 years ago.
Really defer checking condition for classes
18551-3.diff​ (3.3 KB ) - added by Tim Graham 13 years ago.

Download all attachments as: .zip

Change History (9)

by Claude Paroz, 14 years ago

Attachment: 18551.diff​ added

Allow skipUnlessDBFeature / skipIfDBFeature to decorate a class

comment:1 by Claude Paroz, 14 years ago

Has patch: set

comment:2 by Claude Paroz, 14 years ago

Patch needs improvement: set

Obviously the condition is not deferred enough in the "decorator()" definition. Needs more work...

by Claude Paroz, 14 years ago

Attachment: 18551-2.diff​ added

Really defer checking condition for classes

comment:3 by Claude Paroz, 14 years ago

Patch needs improvement: unset

comment:4 by Aymeric Augustin, 14 years ago

Triage Stage: Unreviewed → Accepted

by Tim Graham, 13 years ago

Attachment: 18551-3.diff​ added

comment:5 by Tim Graham, 13 years ago

Triage Stage: Accepted → Ready for checkin

Updated the patch to apply cleanly and get the tests passing on PY3.

comment:6 by Claude Paroz <claude@…>, 13 years ago

Resolution: → fixed
Status: new → closed

In 6d52844b9b3c0bd18eea03ac9dc499782b84c36b:

Fixed #18551 -- Enabled skipIfDBFeature/skipUnlessDBFeature to decorate a class

Thanks Tim Graham for the review and improved patch.

Note: See TracTickets for help on using tickets.
Back to Top